-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roll Skia from add2c39dce6e to 32385b7070a2 (6 revisions) #29626
Merged
fluttergithubbot
merged 1 commit into
flutter:master
from
skia-flutter-autoroll:skia-flutter-autoroll-6dd2881b-9a44-4d53-89db-cb5f9961e4f0-1636497171
Nov 9, 2021
Merged
Roll Skia from add2c39dce6e to 32385b7070a2 (6 revisions) #29626
fluttergithubbot
merged 1 commit into
flutter:master
from
skia-flutter-autoroll:skia-flutter-autoroll-6dd2881b-9a44-4d53-89db-cb5f9961e4f0-1636497171
Nov 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://skia.googlesource.com/skia.git/+log/add2c39dce6e..32385b7070a2 2021-11-09 johnstiles@google.com Report incomplete expression-statements as errors. 2021-11-09 johnstiles@google.com Add test for incomplete expressions. 2021-11-09 johnstiles@google.com Enable constant-expression folding at all times. 2021-11-09 brianosman@google.com Add a color-spin control to Viewer 2021-11-09 brianosman@google.com Clamp lighting dot product in paint_alpha_normals_rt 2021-11-09 drott@chromium.org COLRv1 GM test for foreground color If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
skia-flutter-autoroll
added
the
waiting for tree to go green
This PR is approved and tested, but waiting for the tree to be green to land.
label
Nov 9, 2021
skia-flutter-autoroll
force-pushed
the
skia-flutter-autoroll-6dd2881b-9a44-4d53-89db-cb5f9961e4f0-1636497171
branch
from
November 9, 2021 22:33
981f089
to
cca3f78
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 10, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 10, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 10, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 10, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 10, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 10, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 10, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 10, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 10, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 10, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 10, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 10, 2021
skia-flutter-autoroll
deleted the
skia-flutter-autoroll-6dd2881b-9a44-4d53-89db-cb5f9961e4f0-1636497171
branch
November 16, 2021 22:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla: yes
waiting for tree to go green
This PR is approved and tested, but waiting for the tree to be green to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://skia.googlesource.com/skia.git/+log/add2c39dce6e..32385b7070a2
2021-11-09 johnstiles@google.com Report incomplete expression-statements as errors.
2021-11-09 johnstiles@google.com Add test for incomplete expressions.
2021-11-09 johnstiles@google.com Enable constant-expression folding at all times.
2021-11-09 brianosman@google.com Add a color-spin control to Viewer
2021-11-09 brianosman@google.com Clamp lighting dot product in paint_alpha_normals_rt
2021-11-09 drott@chromium.org COLRv1 GM test for foreground color
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bsalomon@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md