iOS Background Platform Channels #29665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
force-pushed
the
ios_background_platform_messages
branch
2 times, most recently
from
0e26a3a
to
e96fac1
Compare
gaaclarke
force-pushed
the
ios_background_platform_messages
branch
6 times, most recently
from
8f9bdc2
to
0ba85eb
Compare
dnfield
approved these changes
Nov 19, 2021
| codec:codec | ||
| taskQueue:taskQueue]; | ||
| FlutterMessageHandler handler = ^(id _Nullable message, FlutterReply callback) { | ||
| NSLog(@"hey"); |
There was a problem hiding this comment.
nit: avoid extra logs even in tests
Comment on lines
92
to
94
| // Called from any thread. | ||
| // TODO(gaaclarke: This vestigal from the Android implementation, find a way | ||
| // to migrate this to PlatformMessageHandlerAndroid. |
There was a problem hiding this comment.
Maybe just make it not purely virtual and have a no-op implementation in the base class?
There was a problem hiding this comment.
That just puts wallpaper over the issue. I'd like this to stick out like a sore thumb since it should be fixed. It's just a pain given how things are divided up.
|
...once CI is happy |
|
The luci link is missing but the Mac Unopt failure is https://ci.chromium.org/p/flutter/builders/try/Mac%20Unopt/6227. |
gaaclarke
force-pushed
the
ios_background_platform_messages
branch
from
15b6415
to
02293bb
Compare
gaaclarke
added
the
waiting for tree to go green
|
I'm landing this with luci-engine on red. It's not red if you actually check the status and autoroller PRs are landing and that check is not showing up red for them. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 19, 2021
3 tasks
dnfield
added a commit
that referenced
this pull request
Dec 12, 2021
This was referenced Dec 16, 2021
gaaclarke
added a commit
to gaaclarke/engine
that referenced
this pull request
Jan 5, 2022
8 tasks
gaaclarke
added a commit
that referenced
this pull request
Jan 12, 2022
JsouLiang
pushed a commit
to JsouLiang/engine
that referenced
this pull request
Jan 14, 2022
* iOS Background Platform Channels (flutter#29665) * added test that passes before this change, and fails after it * started supporting backwards compatible usage of setting handlers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: flutter/flutter#91635
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.