Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iOS 15 scenario images #30273

Closed
wants to merge 6 commits into from
Closed

Add iOS 15 scenario images #30273

wants to merge 6 commits into from

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Dec 10, 2021

Add scenario app goldens for iOS 15. Always run on latest iOS so these tests will pass against versions of Xcode with different iOS SDKs available (as long as the images are checked in for the SDK).

Follow up to #30263
Part of flutter/flutter#85555.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Dec 10, 2021
@jmagman
Copy link
Member Author

jmagman commented Jan 15, 2022

Closing, just going to wait for flutter/flutter#91689 and do this properly.

@jmagman jmagman closed this Jan 15, 2022
@jmagman jmagman deleted the scenario-15 branch January 15, 2022 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant