Add iOS version to scenario golden images #30263

jmagman · 2021-12-10T05:04:25Z

Add the OS version to the golden image file to allow the tests to pass when on different iOS versions. After this PR, I will add _15.0_ goldens so these tests will also pass on Xcode 15.

Rename, but do not otherwise change, the test images. Remove a few unused images that were not included in the Xcode project.

I previously tried to make the tests pass on both old and new versions of Xcode, but it was reverted #30104. I pulled over some of the random fixes from that PR.

Passing: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8828259508829493713/+/u/test:_Scenario_App_Integration_Tests/stdout

Part of flutter/flutter#85555.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jmagman · 2021-12-10T05:05:26Z

testing/scenario_app/ios/Scenarios/ScenariosUITests/GoldenImage.m

@@ -102,10 +102,11 @@ - (BOOL)compareGoldenToImage:(UIImage*)image {
 }

 NS_INLINE NSString* _platformName() {
+  NSString* systemVersion = UIDevice.currentDevice.systemVersion;


This is the main change--golden_bogus_font_text_iPhone 8_13.0_simulator.png and golden_bogus_font_text_iPhone 8_15.0_simulator.png can both be checked in.

jmagman · 2021-12-10T05:06:44Z

testing/scenario_app/ios/Scenarios/ScenariosUITests/SpawnEngineTest.m

+  XCTAssertTrue([addTextField waitForExistenceWithTimeout:30]);
+
+  GoldenTestManager* manager =
+      [[GoldenTestManager alloc] initWithLaunchArg:@"--spawn-engine-works"];


Make this test use GoldenTestManager so it isn't doing one-off screenshots.

jmagman · 2021-12-10T05:06:54Z

testing/scenario_app/ios/Scenarios/ScenariosUITests/iPadGestureTests.m

@@ -192,7 +192,7 @@ - (void)testPointerHover {
  XCTAssertNotEqual(lastHoverSequenceNumber, -1,
                    @"PointerChange.hover event did not occur for a hover");
  NSString* removeMessage = [NSString
-      stringWithFormat:@"%d,PointerChange.remove,device=0,buttons=0", lastHoverSequenceNumber + 1];
+      stringWithFormat:@"%ld,PointerChange.remove,device=0,buttons=0", lastHoverSequenceNumber + 1];


Fix a warning.

cyanglaz

LGTM

* 37223ca [fuchsia] Use network-legacy-deprecated pkg in embedder test (flutter/engine#30244) * 86769ee Roll Dart SDK from 2ace65b1b408 to 2091ff49c513 (8 revisions) (flutter/engine#30251) * 5312e55 Win32: Handle OnAccessibilityEvent (flutter/engine#30176) * 8fd8912 Revert the latest rolls of the Fuchsia SDK (flutter/engine#30254) * df21689 Call IAccessible::accFocus to move a11y focus (flutter/engine#30256) * 6aa8d5c Simplify win32 platform node delegate GetParent (flutter/engine#30258) * ff328f0 Fix TestAccessibilityBridgeDelegate event caching (flutter/engine#30260) * 842281e Test shell/platform/common a11y code on Windows (flutter/engine#30262) * 806d8bc Roll Dart SDK from 2091ff49c513 to 7b6056f9db7f (1 revision) (flutter/engine#30259) * 1ed10bb Android accessibility bridge also fire selection change event when it predict selection change. (flutter/engine#30199) * 71fdb89 Override FlutterPlatformNodeDelegate::GetUniqueId (flutter/engine#30261) * 5aa7b30 Cleanup old ndk CIPD upload script (flutter/engine#30253) * 3653881 Roll Fuchsia Mac SDK from EcjcLVqar... to 1DgBWWOWV... (flutter/engine#30265) * f764864 Roll Skia from 44c81d149273 to a964a72174e8 (9 revisions) (flutter/engine#30255) * 2eca05e Migrate to Mockito 4.1.0 (flutter/engine#30257) * 1a6005f Add iOS version to scenario golden images (flutter/engine#30263) * 59c6f28 Roll Fuchsia Linux SDK from 3rLypXNTd... to UPWdoQziF... (flutter/engine#30266) * 5502a0a Fix eglPresentationTimeANDROID is no effective (flutter/engine#30182) * bb20dd0 Roll Skia from a964a72174e8 to 4d35c0d31d79 (16 revisions) (flutter/engine#30269) * 33f4c32 Revert "Accessibility number formatting improvements for Windows (#29773)" (flutter/engine#30267) * 5ece42f Roll Dart SDK from 7b6056f9db7f to f568598a262e (4 revisions) (flutter/engine#30270) * 8d1272b Roll Dart SDK from f568598a262e to 49d5a2f58c4a (3 revisions) (flutter/engine#30277) * 8b074c8 Roll Fuchsia Mac SDK from 1DgBWWOWV... to GoQ7KEnqp... (flutter/engine#30278) * e1a71cf Roll Fuchsia Linux SDK from UPWdoQziF... to hhFGKobVD... (flutter/engine#30279) * 6dc4046 Roll Fuchsia Mac SDK from GoQ7KEnqp... to Y_9lCzY64... (flutter/engine#30280) * ff7d4d6 Roll Fuchsia Linux SDK from hhFGKobVD... to NAkkk-Vn5... (flutter/engine#30281) * 2f97ac4 Roll Dart SDK from 49d5a2f58c4a to 01a9d4e9ede7 (1 revision) (flutter/engine#30283) * 85f4d68 Roll Fuchsia Linux SDK from NAkkk-Vn5... to V2JLZw4H1... (flutter/engine#30285) * 5130b83 Roll Fuchsia Mac SDK from Y_9lCzY64... to xBCcWw6gj... (flutter/engine#30284) * e28882a Roll Dart SDK from 01a9d4e9ede7 to a78eae43582d (1 revision) (flutter/engine#30288) * 368e3cc Revert Dart SDK to 2ace65b1b408 (flutter/engine#30290)

Add iOS version to golden images

7343376

jmagman self-assigned this Dec 10, 2021

jmagman commented Dec 10, 2021

View reviewed changes

jmagman changed the title ~~Add iOS version to golden images~~ Add iOS version to scenario golden images Dec 10, 2021

jmagman requested a review from cyanglaz December 10, 2021 05:41

cyanglaz approved these changes Dec 10, 2021

View reviewed changes

jmagman added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Dec 10, 2021

fluttergithubbot merged commit 1a6005f into flutter:main Dec 10, 2021

engine-flutter-autoroll mentioned this pull request Dec 10, 2021

Roll Engine from 79f750d4a541 to 5502a0ad57b7 (18 revisions) flutter/flutter#95042

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 10, 2021

1a6005f Add iOS version to scenario golden images (flutter/engine#30263)

acf75a0

jmagman deleted the scenario-version-sim branch December 10, 2021 22:18

engine-flutter-autoroll mentioned this pull request Dec 10, 2021

Roll Engine from 79f750d4a541 to 5ece42fee466 (21 revisions) flutter/flutter#95052

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 10, 2021

1a6005f Add iOS version to scenario golden images (flutter/engine#30263)

5785f28

jmagman mentioned this pull request Dec 10, 2021

Add iOS 15 scenario images #30273

Closed

8 tasks

engine-flutter-autoroll mentioned this pull request Dec 11, 2021

Roll Engine from 79f750d4a541 to 5ece42fee466 (21 revisions) flutter/flutter#95062

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021

1a6005f Add iOS version to scenario golden images (flutter/engine#30263)

b731df9

engine-flutter-autoroll mentioned this pull request Dec 11, 2021

Roll Engine from 79f750d4a541 to 5ece42fee466 (21 revisions) flutter/flutter#95067

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021

1a6005f Add iOS version to scenario golden images (flutter/engine#30263)

4600461

engine-flutter-autoroll mentioned this pull request Dec 11, 2021

Roll Engine from 79f750d4a541 to 8d1272ba34d5 (22 revisions) flutter/flutter#95072

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021

1a6005f Add iOS version to scenario golden images (flutter/engine#30263)

44ab24f

engine-flutter-autoroll mentioned this pull request Dec 11, 2021

Roll Engine from 79f750d4a541 to 8b074c8159a6 (23 revisions) flutter/flutter#95077

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021

1a6005f Add iOS version to scenario golden images (flutter/engine#30263)

425f634

engine-flutter-autoroll mentioned this pull request Dec 11, 2021

Roll Engine from 79f750d4a541 to e1a71cf0daf8 (24 revisions) flutter/flutter#95078

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021

1a6005f Add iOS version to scenario golden images (flutter/engine#30263)

e8b3e28

engine-flutter-autoroll mentioned this pull request Dec 11, 2021

Roll Engine from 79f750d4a541 to e1a71cf0daf8 (24 revisions) flutter/flutter#95081

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021

1a6005f Add iOS version to scenario golden images (flutter/engine#30263)

b7a3001

engine-flutter-autoroll mentioned this pull request Dec 11, 2021

Roll Engine from 79f750d4a541 to e1a71cf0daf8 (24 revisions) flutter/flutter#95086

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021

1a6005f Add iOS version to scenario golden images (flutter/engine#30263)

3c50696

engine-flutter-autoroll mentioned this pull request Dec 11, 2021

Roll Engine from 79f750d4a541 to ff7d4d6a0920 (26 revisions) flutter/flutter#95096

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021

1a6005f Add iOS version to scenario golden images (flutter/engine#30263)

4500747

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to ff7d4d6a0920 (26 revisions) flutter/flutter#95099

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

1a6005f Add iOS version to scenario golden images (flutter/engine#30263)

c7b5e34

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to 2f97ac4217b1 (27 revisions) flutter/flutter#95102

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

1a6005f Add iOS version to scenario golden images (flutter/engine#30263)

be5bafe

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to 2f97ac4217b1 (27 revisions) flutter/flutter#95106

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

1a6005f Add iOS version to scenario golden images (flutter/engine#30263)

1afa077

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to 2f97ac4217b1 (27 revisions) flutter/flutter#95111

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

1a6005f Add iOS version to scenario golden images (flutter/engine#30263)

97ddc38

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to 85f4d6861a5c (28 revisions) flutter/flutter#95112

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

1a6005f Add iOS version to scenario golden images (flutter/engine#30263)

32f0511

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to 5130b83da049 (29 revisions) flutter/flutter#95114

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

1a6005f Add iOS version to scenario golden images (flutter/engine#30263)

c4f704f

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to 5130b83da049 (29 revisions) flutter/flutter#95119

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

1a6005f Add iOS version to scenario golden images (flutter/engine#30263)

5d65529

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to 5130b83da049 (29 revisions) flutter/flutter#95124

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

1a6005f Add iOS version to scenario golden images (flutter/engine#30263)

c5d752f

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to e28882a1efdc (30 revisions) flutter/flutter#95128

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

1a6005f Add iOS version to scenario golden images (flutter/engine#30263)

a5d504b

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to 368e3cc50592 (31 revisions) flutter/flutter#95132

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

1a6005f Add iOS version to scenario golden images (flutter/engine#30263)

2cafbd2

jmagman added platform-ios affects: tests labels Feb 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add iOS version to scenario golden images #30263

Add iOS version to scenario golden images #30263

jmagman commented Dec 10, 2021 •

edited

Loading

jmagman Dec 10, 2021

jmagman Dec 10, 2021

jmagman Dec 10, 2021

cyanglaz left a comment

Add iOS version to scenario golden images #30263

Add iOS version to scenario golden images #30263

Conversation

jmagman commented Dec 10, 2021 • edited Loading

Pre-launch Checklist

jmagman Dec 10, 2021

Choose a reason for hiding this comment

jmagman Dec 10, 2021

Choose a reason for hiding this comment

jmagman Dec 10, 2021

Choose a reason for hiding this comment

cyanglaz left a comment

Choose a reason for hiding this comment

jmagman commented Dec 10, 2021 •

edited

Loading