Add configuration to support compiling engine with SUPPORT_FRACTIONAL_TRANSLATION #33393
Conversation
| @@ -68,10 +68,10 @@ class TesterGPUSurfaceSoftware : public GPUSurfaceSoftware { | |||
| bool render_to_surface) | |||
| : GPUSurfaceSoftware(delegate, render_to_surface) {} | |||
|
|
|||
| #if DISABLE_SOFTWARE_RASTER_CACHE | |||
| #if SUPPORT_FRACTIONAL_TRANSLATION | |||
There was a problem hiding this comment.
Might as well key this off of SUPPORT_FRACTIONAL_TRANSLATION, so we only need to change the location of the downloaded artifact and not the name too. I'll send a PR to revert the recipe change later
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Sounds good - we should only need a linux host variant with this define enabled |
|
One more update: needed to change the out_dir so we don't conflict with the normal debug engine variant |
|
"stabletest" would be a bit optimistic 😄 . I think with flutter/flutter#103909, we'll switch to this by default for all desktop platforms and this variant will go away once we update g3 |
|
@jonahwilliams Looking at the recipe change, I think it might be helpful to spell out the migration plan in a doc or github issue if we don't have one already. |
|
I updated flutter/flutter#103909 with a quick migration plan |
jonahwilliams
added
the
waiting for tree to go green
…ACTIONAL_TRANSLATION (flutter/engine#33393)
|
(for completeness: |
Requires flutter/engine#33393 to build Bug: flutter/flutter#103909 Change-Id: Ia6ae24676214a98459f9e2fb739d160031faa67c Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/30201 Reviewed-by: Zach Anderson <zra@google.com> Commit-Queue: Jonah Williams <jonahwilliams@google.com>
We need to compile a full engine variant to enable SUPPORT_FRACTIONAL_TRANSLATION for tester devices
Work towards flutter/flutter#103909
This is not tested on CI, as the recipe must first be created (as part of this change). To test locally, first build the variant with
flutter/tools/gn --unopt --support-fractional-translationand then run the appropriate unit tests without/host_debug_unopt_fractional/shell_unittests(.exe)andout/host_debug_unopt_fractional/displaylist_unittests(.exe)Edit: or just use .\testing\run_tests.py --variant=host_debug_unopt_fractional