Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fuchsia][a11y] Set explicit hit regions in flatland embedder #37338

Merged
merged 1 commit into from
Nov 18, 2022
Merged

[fuchsia][a11y] Set explicit hit regions in flatland embedder #37338

merged 1 commit into from
Nov 18, 2022

Conversation

abrush21
Copy link
Contributor

@abrush21 abrush21 commented Nov 4, 2022 •
edited
Loading

This change enables the screen reader to interact with flutter overlays on flatland (PR #33852 made the same change for GFX).

fxbug.dev/104956

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@abrush21 abrush21 marked this pull request as ready for review November 7, 2022 19:51
@abrush21 abrush21 changed the title [WIP][fuchsia][a11y] Set explicit hit regions in flatland embedder fuchsia][a11y] Set explicit hit regions in flatland embedder Nov 7, 2022
@abrush21 abrush21 changed the title fuchsia][a11y] Set explicit hit regions in flatland embedder [fuchsia][a11y] Set explicit hit regions in flatland embedder Nov 7, 2022
@abrush21
Copy link
Contributor Author

cc @akbiggs @jaeheon

jaeheon
jaeheon approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@jaeheon jaeheon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Tests look good too, disjoint and overlap cases. Small question about comment refresh.

shell/platform/fuchsia/flutter/flatland_external_view_embedder.cc Show resolved Hide resolved
akbiggs
akbiggs approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@akbiggs akbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow review

@abrush21
Copy link
Contributor Author

@akbiggs can you merge the change, since I don't have committer status? I also requested committer status, so hopefully this is the last time you need to do this for me :)

@jaeheon jaeheon added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 18, 2022
@auto-submit auto-submit bot merged commit 30aa3cc into flutter:main Nov 18, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 18, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 18, 2022
@engine-flutter-autoroll
30aa3cc38 [fuchsia][a11y] Set explicit hit regions in flatland embedd…
02ee8db 
…er (flutter/engine#37338)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 18, 2022
@engine-flutter-autoroll
Roll Flutter Engine from b32c3a307bb5 to 7a390f97c798 (14 revisions) (#…
46d868c 
…115672)

* a76ec9158 Roll Fuchsia Linux SDK from lnmSnyJi-2H07tBnV... to WdtwlLEce90PjFJ9z... (flutter/engine#37747)

* 44e2f5854 [Impeller] Change texture upload pipeline in Vulkan (flutter/engine#37623)

* 6a3ad3c14 Roll Skia from 345bceacd298 to 5270b1d26b5f (4 revisions) (flutter/engine#37748)

* 01271891c Do not abort if a MultiFrameCodec is unable to allocate a bitmap buffer (flutter/engine#37534)

* 54232a4c3 Roll Skia from 5270b1d26b5f to cf967e6b1c00 (5 revisions) (flutter/engine#37751)

* 30aa3cc38 [fuchsia][a11y] Set explicit hit regions in flatland embedder (flutter/engine#37338)

* da07c33d2 Make NotifyIdle reject close and past deadlines. (flutter/engine#37737)

* e3844cc1e Add third_party/dart/third_party/binaryen/src as a dependency (flutter/engine#37749)

* aeb2cd95b [Impeller] use SSBOs for gradients where supported (metal/vulkan) (flutter/engine#37654)

* e8aa1c192 Roll Skia from cf967e6b1c00 to f1f59de17204 (2 revisions) (flutter/engine#37756)

* 4311774fb [Impeller] register modern shaders on Vulkan too (flutter/engine#37757)

* 8e4a718d0 Made FlutterTextField that outlive FlutterTextPlatformNode not crash (flutter/engine#37735)

* 446a09dfc [macOS] Use consistent filenames for tests (flutter/engine#37755)

* 7a390f97c Roll Skia from f1f59de17204 to 12f01bc5b57e (1 revision) (flutter/engine#37760)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
@engine-flutter-autoroll @shogohida
Roll Flutter Engine from b32c3a307bb5 to 7a390f97c798 (14 revisions) (f…
dd66b0b 
…lutter#115672)

* a76ec9158 Roll Fuchsia Linux SDK from lnmSnyJi-2H07tBnV... to WdtwlLEce90PjFJ9z... (flutter/engine#37747)

* 44e2f5854 [Impeller] Change texture upload pipeline in Vulkan (flutter/engine#37623)

* 6a3ad3c14 Roll Skia from 345bceacd298 to 5270b1d26b5f (4 revisions) (flutter/engine#37748)

* 01271891c Do not abort if a MultiFrameCodec is unable to allocate a bitmap buffer (flutter/engine#37534)

* 54232a4c3 Roll Skia from 5270b1d26b5f to cf967e6b1c00 (5 revisions) (flutter/engine#37751)

* 30aa3cc38 [fuchsia][a11y] Set explicit hit regions in flatland embedder (flutter/engine#37338)

* da07c33d2 Make NotifyIdle reject close and past deadlines. (flutter/engine#37737)

* e3844cc1e Add third_party/dart/third_party/binaryen/src as a dependency (flutter/engine#37749)

* aeb2cd95b [Impeller] use SSBOs for gradients where supported (metal/vulkan) (flutter/engine#37654)

* e8aa1c192 Roll Skia from cf967e6b1c00 to f1f59de17204 (2 revisions) (flutter/engine#37756)

* 4311774fb [Impeller] register modern shaders on Vulkan too (flutter/engine#37757)

* 8e4a718d0 Made FlutterTextField that outlive FlutterTextPlatformNode not crash (flutter/engine#37735)

* 446a09dfc [macOS] Use consistent filenames for tests (flutter/engine#37755)

* 7a390f97c Roll Skia from f1f59de17204 to 12f01bc5b57e (1 revision) (flutter/engine#37760)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@engine-flutter-autoroll @gspencergoog
Roll Flutter Engine from b32c3a307bb5 to 7a390f97c798 (14 revisions) (f…
151ae42 
…lutter#115672)

* a76ec9158 Roll Fuchsia Linux SDK from lnmSnyJi-2H07tBnV... to WdtwlLEce90PjFJ9z... (flutter/engine#37747)

* 44e2f5854 [Impeller] Change texture upload pipeline in Vulkan (flutter/engine#37623)

* 6a3ad3c14 Roll Skia from 345bceacd298 to 5270b1d26b5f (4 revisions) (flutter/engine#37748)

* 01271891c Do not abort if a MultiFrameCodec is unable to allocate a bitmap buffer (flutter/engine#37534)

* 54232a4c3 Roll Skia from 5270b1d26b5f to cf967e6b1c00 (5 revisions) (flutter/engine#37751)

* 30aa3cc38 [fuchsia][a11y] Set explicit hit regions in flatland embedder (flutter/engine#37338)

* da07c33d2 Make NotifyIdle reject close and past deadlines. (flutter/engine#37737)

* e3844cc1e Add third_party/dart/third_party/binaryen/src as a dependency (flutter/engine#37749)

* aeb2cd95b [Impeller] use SSBOs for gradients where supported (metal/vulkan) (flutter/engine#37654)

* e8aa1c192 Roll Skia from cf967e6b1c00 to f1f59de17204 (2 revisions) (flutter/engine#37756)

* 4311774fb [Impeller] register modern shaders on Vulkan too (flutter/engine#37757)

* 8e4a718d0 Made FlutterTextField that outlive FlutterTextPlatformNode not crash (flutter/engine#37735)

* 446a09dfc [macOS] Use consistent filenames for tests (flutter/engine#37755)

* 7a390f97c Roll Skia from f1f59de17204 to 12f01bc5b57e (1 revision) (flutter/engine#37760)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeheon jaeheon jaeheon approved these changes

@akbiggs akbiggs akbiggs approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-fuchsia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abrush21 @jaeheon @akbiggs