[canvaskit] Fix Shader program tests #37644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
yjbanov
approved these changes
Nov 16, 2022
harryterkelsen
added
autosubmit
eyebrowsoffire
approved these changes
Nov 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 3, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 3, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 3, 2022
…116447) * bebc12fd0 Roll Skia from 28c1bbab82b8 to 6fdf7181e374 (16 revisions) (flutter/engine#38046) * 2c1e5efae [Impeller] add --enable-impeller-3d flag to support scene experimentation (flutter/engine#37990) * 8e11659a8 [canvaskit] Fix Shader program tests (flutter/engine#37644) * 850c4ad68 [canvaskit] Fix Surface test (flutter/engine#37636) * f7df812d2 save (flutter/engine#37107)
mit-mit
pushed a commit
to mit-mit/flutter
that referenced
this pull request
Dec 6, 2022
…lutter#116447) * bebc12fd0 Roll Skia from 28c1bbab82b8 to 6fdf7181e374 (16 revisions) (flutter/engine#38046) * 2c1e5efae [Impeller] add --enable-impeller-3d flag to support scene experimentation (flutter/engine#37990) * 8e11659a8 [canvaskit] Fix Shader program tests (flutter/engine#37644) * 850c4ad68 [canvaskit] Fix Surface test (flutter/engine#37636) * f7df812d2 save (flutter/engine#37107)
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#116447) * bebc12fd0 Roll Skia from 28c1bbab82b8 to 6fdf7181e374 (16 revisions) (flutter/engine#38046) * 2c1e5efae [Impeller] add --enable-impeller-3d flag to support scene experimentation (flutter/engine#37990) * 8e11659a8 [canvaskit] Fix Shader program tests (flutter/engine#37644) * 850c4ad68 [canvaskit] Fix Surface test (flutter/engine#37636) * f7df812d2 save (flutter/engine#37107)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#116447) * bebc12fd0 Roll Skia from 28c1bbab82b8 to 6fdf7181e374 (16 revisions) (flutter/engine#38046) * 2c1e5efae [Impeller] add --enable-impeller-3d flag to support scene experimentation (flutter/engine#37990) * 8e11659a8 [canvaskit] Fix Shader program tests (flutter/engine#37644) * 850c4ad68 [canvaskit] Fix Surface test (flutter/engine#37636) * f7df812d2 save (flutter/engine#37107)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the fragment shader tests that regressed as a result of test results not being reported properly.
skip: !isRuntimeEffectAvailabledoesn't work here because even when it is available (when running against a locally-built CanvasKit), the test is skipped anyway. I suspect that the skip checks are done before CanvasKit is initialized.Partially addresses flutter/flutter#115327
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.