Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[obsolete] Call focus on input after detecting a tap #37732

Closed
wants to merge 93 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
93 commits
Select commit Hold shift + click to select a range
c13a84e
call focus on input after detecting a tap
Nov 17, 2022
1f4ddc3
Only run clang-tidy warning checks reported as errors (#36885)
jmagman Nov 18, 2022
e812122
Roll Fuchsia Linux SDK from JzUXGxIUUNgr8qJUx... to lnmSnyJi-2H07tBnV…
skia-flutter-autoroll Nov 18, 2022
f27666d
[macOS] Merge FlutterBackingStore implementations (#37730)
cbracken Nov 18, 2022
5471734
[macOS] Cleanup unnecessary references to Metal (#37733)
cbracken Nov 18, 2022
39f5465
Fix CanvasKit path tests (#37635)
hterkelsen Nov 18, 2022
04aea3c
iOS PlatformView only sets a maskView when necessary (#37434)
Nov 18, 2022
4ca2c1d
Roll Skia from 55f654bf5cff to 9d56e506b4df (13 revisions) (#37739)
skia-flutter-autoroll Nov 18, 2022
a627367
Roll Skia from 9d56e506b4df to d693b4b9fe5e (5 revisions) (#37741)
skia-flutter-autoroll Nov 18, 2022
f092cd8
Roll Fuchsia Mac SDK from SVtX810D2U_ZgBcpx... to tklUfTsSOVKk49tYq..…
skia-flutter-autoroll Nov 18, 2022
ca5b2f3
Roll Skia from d693b4b9fe5e to ab054a88d7c7 (1 revision) (#37743)
skia-flutter-autoroll Nov 18, 2022
b32c3a3
Roll Skia from ab054a88d7c7 to 345bceacd298 (3 revisions) (#37745)
skia-flutter-autoroll Nov 18, 2022
a76ec91
Roll Fuchsia Linux SDK from lnmSnyJi-2H07tBnV... to WdtwlLEce90PjFJ9z…
skia-flutter-autoroll Nov 18, 2022
44e2f58
[Impeller] Change texture upload pipeline in Vulkan (#37623)
iskakaushik Nov 18, 2022
6a3ad3c
Roll Skia from 345bceacd298 to 5270b1d26b5f (4 revisions) (#37748)
skia-flutter-autoroll Nov 18, 2022
0127189
Do not abort if a MultiFrameCodec is unable to allocate a bitmap buff…
jason-simmons Nov 18, 2022
54232a4
Roll Skia from 5270b1d26b5f to cf967e6b1c00 (5 revisions) (#37751)
skia-flutter-autoroll Nov 18, 2022
30aa3cc
[fuchsia][a11y] Set explicit hit regions in flatland embedder (#37338)
abrush21 Nov 18, 2022
da07c33
Make NotifyIdle reject close and past deadlines. (#37737)
dnfield Nov 18, 2022
e3844cc
Add third_party/dart/third_party/binaryen/src as a dependency (#37749)
jason-simmons Nov 18, 2022
aeb2cd9
[Impeller] use SSBOs for gradients where supported (metal/vulkan) (#3…
jonahwilliams Nov 18, 2022
e8aa1c1
Roll Skia from cf967e6b1c00 to f1f59de17204 (2 revisions) (#37756)
skia-flutter-autoroll Nov 18, 2022
4311774
[Impeller] register modern shaders on Vulkan too (#37757)
jonahwilliams Nov 18, 2022
8e4a718
Made FlutterTextField that outlive FlutterTextPlatformNode not crash …
gaaclarke Nov 18, 2022
446a09d
[macOS] Use consistent filenames for tests (#37755)
cbracken Nov 18, 2022
7a390f9
Roll Skia from f1f59de17204 to 12f01bc5b57e (1 revision) (#37760)
skia-flutter-autoroll Nov 18, 2022
a77dfaf
Remove `Linux Web Engine` from recipes CQ (#37758)
keyonghan Nov 18, 2022
f81ac3b
Fix glyph sampling overlap (#37764)
bdero Nov 19, 2022
cef11cb
Roll Skia from 12f01bc5b57e to c53d8cf5b823 (4 revisions) (#37767)
skia-flutter-autoroll Nov 19, 2022
6da5940
Roll Skia from c53d8cf5b823 to 0c1fcbe97b1f (1 revision) (#37771)
skia-flutter-autoroll Nov 19, 2022
91bc694
Roll Fuchsia Mac SDK from tklUfTsSOVKk49tYq... to UcfQiA4PBOCs_7GEK..…
skia-flutter-autoroll Nov 19, 2022
2d5e066
Roll Fuchsia Linux SDK from WdtwlLEce90PjFJ9z... to qc20R_3e8PoqMQWgw…
skia-flutter-autoroll Nov 19, 2022
916fd79
Roll Skia from 0c1fcbe97b1f to ad354e712b96 (2 revisions) (#37776)
skia-flutter-autoroll Nov 19, 2022
42cc4d1
Roll Skia from ad354e712b96 to 80b3e3d24a99 (3 revisions) (#37780)
skia-flutter-autoroll Nov 19, 2022
9a7336d
Roll Fuchsia Mac SDK from UcfQiA4PBOCs_7GEK... to C8_lxtWKA4MIKeAu2..…
skia-flutter-autoroll Nov 19, 2022
e9bdd5e
Roll Fuchsia Linux SDK from qc20R_3e8PoqMQWgw... to Cg4pM7Agigl6gZqq5…
skia-flutter-autoroll Nov 19, 2022
79bc945
Roll Fuchsia Mac SDK from C8_lxtWKA4MIKeAu2... to KqMuhIlNeJZpycJLZ..…
skia-flutter-autoroll Nov 20, 2022
bb283b4
Roll Fuchsia Linux SDK from Cg4pM7Agigl6gZqq5... to 2T1QqkhI-ef8AXGgn…
skia-flutter-autoroll Nov 20, 2022
c653da3
Roll Skia from 80b3e3d24a99 to dd5f384ae62a (1 revision) (#37786)
skia-flutter-autoroll Nov 20, 2022
774bce8
Roll Skia from dd5f384ae62a to 1d7f785e3679 (1 revision) (#37787)
skia-flutter-autoroll Nov 20, 2022
3bdce10
Roll Skia from 1d7f785e3679 to ea4307d60150 (1 revision) (#37788)
skia-flutter-autoroll Nov 20, 2022
7053227
Roll Fuchsia Mac SDK from KqMuhIlNeJZpycJLZ... to VeOzYBpD9mZ9VZXxv..…
skia-flutter-autoroll Nov 20, 2022
ba7d6d6
Roll Skia from ea4307d60150 to db7a810dba5d (1 revision) (#37792)
skia-flutter-autoroll Nov 20, 2022
2714618
Roll Fuchsia Linux SDK from 2T1QqkhI-ef8AXGgn... to EyQx0yUqK5TJxeHF7…
skia-flutter-autoroll Nov 20, 2022
4affb2a
Roll Skia from db7a810dba5d to 645605735772 (1 revision) (#37796)
skia-flutter-autoroll Nov 21, 2022
18a5b35
Roll Skia from 645605735772 to ae61b83805e3 (3 revisions) (#37797)
skia-flutter-autoroll Nov 21, 2022
913fa02
Roll Fuchsia Mac SDK from VeOzYBpD9mZ9VZXxv... to rApsrzmdh6Pxy9WkO..…
skia-flutter-autoroll Nov 21, 2022
46a6b54
Add package:ffi as path dependency to flutter_frontend_server (#37802)
mkustermann Nov 21, 2022
3de8621
Roll Skia from ae61b83805e3 to b0e1c4c8c3a6 (2 revisions) (#37803)
skia-flutter-autoroll Nov 21, 2022
5c3b895
Roll Skia from b0e1c4c8c3a6 to f7b5a76b6f35 (1 revision) (#37806)
skia-flutter-autoroll Nov 21, 2022
55b0891
Roll Fuchsia Linux SDK from EyQx0yUqK5TJxeHF7... to xBfEjlXUsix6Wka-i…
skia-flutter-autoroll Nov 21, 2022
4a4df4b
[Impeller] Format shader sources. (#37770)
dnfield Nov 21, 2022
09b82e0
Roll Dart SDK from c3f1b3642181 to 68291f382fb6 (7 revisions) (#37808)
skia-flutter-autoroll Nov 21, 2022
49db609
[Impeller] Present Impeller contents in a transaction when there is a…
zanderso Nov 21, 2022
21ce09a
Add optional offset parameter to ImageFilterLayer (#36863)
flar Nov 21, 2022
cc0ad66
Roll Skia from f7b5a76b6f35 to b5b35f8dc919 (5 revisions) (#37810)
skia-flutter-autoroll Nov 21, 2022
9ea061b
[macOS] Add explicit weak/strong/copy annotations (#37768)
cbracken Nov 21, 2022
2a8ac1e
[Linux] Synthesize modifier keys events on pointer events (#37491)
bleroux Nov 21, 2022
44f22ac
Roll Dart SDK from 68291f382fb6 to 756f835dd84d (1 revision) (#37815)
skia-flutter-autoroll Nov 21, 2022
c368031
Roll Skia from b5b35f8dc919 to 500aae3f2761 (5 revisions) (#37817)
skia-flutter-autoroll Nov 21, 2022
981fe92
Roll Fuchsia Mac SDK from rApsrzmdh6Pxy9WkO... to oaqX39ssn3PUxE9it..…
skia-flutter-autoroll Nov 21, 2022
ddf6a20
Roll Skia from 500aae3f2761 to 57b4252cf211 (7 revisions) (#37819)
skia-flutter-autoroll Nov 21, 2022
8dd8e09
Roll Dart SDK from 756f835dd84d to 6b8e98070f26 (1 revision) (#37825)
skia-flutter-autoroll Nov 22, 2022
c3645c3
[impeller] Remove declare_undefined_values (#37829)
Nov 22, 2022
eba7ecd
Add setImageSampler (for replacing setSampler) (#37821)
bdero Nov 22, 2022
15dce5e
Roll Skia from 57b4252cf211 to 550fd51bd254 (3 revisions) (#37830)
skia-flutter-autoroll Nov 22, 2022
9b07044
Revert "[impeller] Remove declare_undefined_values (#37829)" (#37831)
zanderso Nov 22, 2022
1a61808
Roll Dart SDK from 6b8e98070f26 to 27c45cd51796 (1 revision) (#37833)
skia-flutter-autoroll Nov 22, 2022
8bc4154
Roll Skia from 550fd51bd254 to 94c63addc990 (1 revision) (#37834)
skia-flutter-autoroll Nov 22, 2022
7b42915
Roll Skia from 94c63addc990 to 0dec6d1823b3 (4 revisions) (#37836)
skia-flutter-autoroll Nov 22, 2022
a7fa7c6
Roll Fuchsia Linux SDK from xBfEjlXUsix6Wka-i... to 5Xd8MJTM-pWPWCgUa…
skia-flutter-autoroll Nov 22, 2022
b6e33b5
Roll Fuchsia Mac SDK from oaqX39ssn3PUxE9it... to mwKdD1jX_KVP1U76z..…
skia-flutter-autoroll Nov 22, 2022
37e2aaa
Roll Skia from 0dec6d1823b3 to 3b2d9e4bf668 (1 revision) (#37845)
skia-flutter-autoroll Nov 22, 2022
c05e7ff
[Impeller] opt float/sampler into relaxed precision for gles (#37828)
jonahwilliams Nov 22, 2022
256dc78
Reland "[web] Avoid returning int from js interop classes." (#37627)
joshualitt Nov 22, 2022
5ab29c9
[web] Move unicode properties to third_party (#37440)
mdebbar Nov 22, 2022
10da1a1
Remove setSampler from FragmentShader (#37839)
bdero Nov 22, 2022
a800e76
[Impeller] make VerticesGeometry delegate to the DL class (#37835)
jonahwilliams Nov 22, 2022
1067cd2
Roll Skia from 3b2d9e4bf668 to 3bd2fe46f6d2 (2 revisions) (#37848)
skia-flutter-autoroll Nov 22, 2022
2d8e539
change cloneImageElement() to return clone every time (#37811)
alanwutang11 Nov 22, 2022
cefb954
fix pixel ratio (#37268)
cfontas Nov 22, 2022
c6b2ced
Set nested clip nodes (#37850)
uysalere Nov 22, 2022
c7ecca8
Roll Skia from 3bd2fe46f6d2 to c098e3c5d932 (2 revisions) (#37851)
skia-flutter-autoroll Nov 22, 2022
afac22d
Made platform message responses threadsafe for macos. (#37607)
gaaclarke Nov 22, 2022
a805eff
fix docs analysis error on setImageSampler (#37852)
jonahwilliams Nov 22, 2022
3c27847
Turn on darwin-* clang-tidy checks (#37814)
jmagman Nov 22, 2022
4bf16c3
Turn on objc-* clang-tidy checks (#37813)
jmagman Nov 22, 2022
8e458a2
[Impeller] Set color attachment pixel format to RGBA on OpenGLES back…
ColdPaleLight Nov 22, 2022
f75287a
[Windows] Refactor `PlatformHandler`'s tests (#37820)
loic-sharma Nov 22, 2022
a43142d
Roll Dart SDK from 27c45cd51796 to d2766b385c2a (5 revisions) (#37859)
skia-flutter-autoroll Nov 23, 2022
826854c
call focus on input after detecting a tap
Nov 17, 2022
d0c8ff8
Merge branch 'voiceover-keyboard' of github.com:nbayati/engine into v…
Nov 23, 2022
a2e62ac
add unit tests
Nov 23, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 0 additions & 1 deletion .ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,6 @@ targets:

- name: Linux Web Engine
recipe: engine/web_engine
bringup: true
properties:
add_recipes_cq: "true"
cores: "32"
Expand Down
23 changes: 6 additions & 17 deletions .clang-tidy
Original file line number Diff line number Diff line change
Expand Up @@ -4,35 +4,24 @@
Checks: "bugprone-use-after-move,\
clang-analyzer-*,\
clang-diagnostic-*,\
darwin-*,\
google-*,\
modernize-use-default-member-init,\
objc-*,\
-objc-nsinvocation-argument-lifetime,\
readability-identifier-naming,\
-google-build-using-namespace,\
-google-default-arguments,\
-google-objc-global-variable-declaration,\
-google-objc-avoid-throwing-exception,\
-google-readability-casting,\
-clang-analyzer-nullability.NullPassedToNonnull,\
-clang-analyzer-nullability.NullablePassedToNonnull,\
-clang-analyzer-nullability.NullReturnedFromNonnull,\
-clang-analyzer-nullability.NullableReturnedFromNonnull,\
performance-move-const-arg,\
performance-unnecessary-value-param"

# Only warnings treated as errors are reported
# in the "ci/lint.sh" script and pre-push git hook.
# Add checks when all warnings are fixed
# to prevent new warnings being introduced.
# https://github.com/flutter/flutter/issues/93279
# Note: There are platform specific warnings as errors in
# //ci/lint.sh
WarningsAsErrors: "bugprone-use-after-move,\
clang-analyzer-*,\
readability-identifier-naming,\
clang-diagnostic-*,\
google-objc-*,\
google-explicit-constructor,\
google-readability-avoid-underscore-in-googletest-name,\
performance-move-const-arg,\
performance-unnecessary-value-param"

CheckOptions:
- key: modernize-use-default-member-init.UseAssignment
value: true
Expand Down
46 changes: 25 additions & 21 deletions DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ vars = {
'llvm_git': 'https://llvm.googlesource.com',
# OCMock is for testing only so there is no google clone
'ocmock_git': 'https://github.com/erikdoe/ocmock.git',
'skia_revision': '55f654bf5cff8eb8a5364725509204271100ca81',
'skia_revision': 'c098e3c5d932798e0381ae452914e2658f20840c',

# WARNING: DO NOT EDIT canvaskit_cipd_instance MANUALLY
# See `lib/web_ui/README.md` for how to roll CanvasKit to a new version.
Expand Down Expand Up @@ -48,22 +48,23 @@ vars = {
# Dart is: https://github.com/dart-lang/sdk/blob/main/DEPS
# You can use //tools/dart/create_updated_flutter_deps.py to produce
# updated revision list of existing dependencies.
'dart_revision': 'c3f1b3642181003576afdab7547f9ed9a1eabe8c',
'dart_revision': 'd2766b385c2a962be208ee51e03e8cfc20ef0351',

# WARNING: DO NOT EDIT MANUALLY
# The lines between blank lines above and below are generated by a script. See create_updated_flutter_deps.py
'dart_binaryen_rev': 'ec53f4b2d5b0d52ae703c5b696ecf052ad5fffbb',
'dart_boringssl_gen_rev': 'ced85ef0a00bbca77ce5a91261a5f2ae61b1e62f',
'dart_boringssl_rev': '87f316d7748268eb56f2dc147bd593254ae93198',
'dart_browser_launcher_rev': '5fa0bd6cddc33785f43c920576fc03dcee1c3caa',
'dart_clock_rev': '8a8231fa7912d84c7e99236b7800cfbef5ea7ae5',
'dart_collection_rev': 'efd709fc1760a595f8575f4137a1847de1b49d76',
'dart_devtools_rev': '23444af89d716818f099974df3e4fffac87fd886',
'dart_protobuf_rev': '4af1cb3c4e116d02d3b3d005fd9d4995fbc4c564',
'dart_protobuf_rev': 'ae90e53cd690edbfc72fa6c293fdb7b4a09ee0a2',
'dart_pub_rev': '6ac42d7644dedfcc500147ab47886eecab4b1b38',
'dart_root_certificates_rev': '692f6d6488af68e0121317a9c2c9eb393eb0ee50',
'dart_watcher_rev': '32591071a83f632478e702f67e29de6e54428ce9',
'dart_webdev_rev': '22f6271c4ae362d7d13cfe14442aecb197140436',
'dart_webkit_inspection_protocol_rev': 'b825c8f6a12200d619729903207ac826cce278da',
'dart_webdev_rev': '3ec168f6815af9d5f11278111d147bc82c0755c3',
'dart_webkit_inspection_protocol_rev': 'ddb624cd85954dd384056cc253a8fc2b9da5364d',
'dart_yaml_edit_rev': '299f74594ff9fda412c1da5c0b5d5231d0c6fc42',
'dart_zlib_rev': '27c2f474b71d0d20764f86f60ef8b00da1a16cda',

Expand Down Expand Up @@ -179,6 +180,9 @@ deps = {

# WARNING: Unused Dart dependencies in the list below till "WARNING:" marker are removed automatically - see create_updated_flutter_deps.py.

'src/third_party/dart/third_party/binaryen/src':
Var('chromium_git') + '/external/github.com/WebAssembly/binaryen.git@ec53f4b2d5b0d52ae703c5b696ecf052ad5fffbb',

'src/third_party/dart/third_party/devtools':
{'packages': [{'version': 'git_revision:23444af89d716818f099974df3e4fffac87fd886', 'package': 'dart/third_party/flutter/devtools'}], 'dep_type': 'cipd'},

Expand All @@ -198,7 +202,7 @@ deps = {
Var('dart_git') + '/browser_launcher.git' + '@' + Var('dart_browser_launcher_rev'),

'src/third_party/dart/third_party/pkg/cli_util':
Var('dart_git') + '/cli_util.git@b0adbba89442b2ea6fef39c7a82fe79cb31e1168',
Var('dart_git') + '/cli_util.git@edcf1c357dfc92f760ea0f1bbdb94f9b72d26b71',

'src/third_party/dart/third_party/pkg/clock':
Var('dart_git') + '/clock.git' + '@' + Var('dart_clock_rev'),
Expand All @@ -213,13 +217,13 @@ deps = {
Var('dart_git') + '/crypto.git@bf0c33b42eb7e5991ee98429318884695e576c2b',

'src/third_party/dart/third_party/pkg/csslib':
Var('dart_git') + '/csslib.git@ba2eb2d80530eedefadaade338a09c2dd60410f3',
Var('dart_git') + '/csslib.git@34203c09f073ed8267f5d6e333daddb02e6ff609',

'src/third_party/dart/third_party/pkg/dart_style':
Var('dart_git') + '/dart_style.git@f79a9828ad07e50d6e8352ac154cc16eb4d78d5c',

'src/third_party/dart/third_party/pkg/dartdoc':
Var('dart_git') + '/dartdoc.git@08e309818acb44ba3dd46ed999bf6b0359c356ff',
Var('dart_git') + '/dartdoc.git@dc502d0862fe1ba8451c9c57cd7ab70432634af3',

'src/third_party/dart/third_party/pkg/ffi':
Var('dart_git') + '/ffi.git@3ede2312dd6ec37db6e7bcd6e1236647f72c7fc0',
Expand All @@ -237,7 +241,7 @@ deps = {
Var('dart_git') + '/html.git@28fb8b97acf471bedcfa4eaf38899a0f65d5e30d',

'src/third_party/dart/third_party/pkg/http':
Var('dart_git') + '/http.git@63390263e230bbd0aa2dae286fd7a64098e09029',
Var('dart_git') + '/http.git@d56141de40b69e8ae3cc22602caea6cca3fba4dc',

'src/third_party/dart/third_party/pkg/http_multi_server':
Var('dart_git') + '/http_multi_server.git@e31c6988e3869fb4019429254604066338f86095',
Expand All @@ -255,22 +259,22 @@ deps = {
Var('dart_git') + '/logging.git@f322480fb9d9e83e677c08db6d09067059f7ff74',

'src/third_party/dart/third_party/pkg/markdown':
Var('dart_git') + '/markdown.git@a70b93a1a004cc1da04a3e3ea59821ef8391e0d6',
Var('dart_git') + '/markdown.git@37951d151750acfae756b2e466f563c1c5119b3d',

'src/third_party/dart/third_party/pkg/matcher':
Var('dart_git') + '/matcher.git@6a9b83bbd73e50df2058b3e8e4aa301df49569c6',
Var('dart_git') + '/matcher.git@15d4af21002ae9adee952110192a3face96307c7',

'src/third_party/dart/third_party/pkg/mime':
Var('dart_git') + '/mime.git@d80f4d09067af87d84d9cb647acfa4d2d313d795',
Var('dart_git') + '/mime.git@c0c4c47a3d7bf696f1aa1959fb83d598baadb33c',

'src/third_party/dart/third_party/pkg/mockito':
Var('dart_git') + '/mockito.git@748e88e4cbf7e3acd1144cd8e3ea4ae87ea8c9c2',
Var('dart_git') + '/mockito.git@347d3e4cc64752b2ff7b5d35fe5cd1b281b17413',

'src/third_party/dart/third_party/pkg/package_config':
Var('dart_git') + '/package_config.git@cff98c90acc457a3b0750f0a7da0e351a35e5d0c',
Var('dart_git') + '/package_config.git@abb4aec904ab8c739b6dcec516d44f56d96c8115',

'src/third_party/dart/third_party/pkg/path':
Var('dart_git') + '/path.git@58ba22c53e40a05c407abb070ec63674b3a38c4d',
Var('dart_git') + '/path.git@12ce876fdd8873128671acfec54c8ad88da361fa',

'src/third_party/dart/third_party/pkg/pool':
Var('dart_git') + '/pool.git@1ea5b031cfda37786d305292cb8104dffb45d9ae',
Expand All @@ -285,7 +289,7 @@ deps = {
Var('dart_git') + '/pub_semver.git@28159b8c5b96fc2709d0904389d7932880f68659',

'src/third_party/dart/third_party/pkg/shelf':
Var('dart_git') + '/shelf.git@5fd2593d47120232054ebcc794f3a028d903f1f8',
Var('dart_git') + '/shelf.git@1c2104737973715426035c11ba840c7f23d8f186',

'src/third_party/dart/third_party/pkg/source_map_stack_trace':
Var('dart_git') + '/source_map_stack_trace.git@8d8078fcc81c8f7936805cd277198493e0b7fc62',
Expand All @@ -309,13 +313,13 @@ deps = {
Var('dart_git') + '/string_scanner.git@4a5cbc5c1127151ea507cc9da797b829857607e8',

'src/third_party/dart/third_party/pkg/term_glyph':
Var('dart_git') + '/term_glyph.git@ec7cf7bb51ebb7d55760a1359f6697690dbc06ba',
Var('dart_git') + '/term_glyph.git@822cd5b3418615c6db715a796c2c9ba9acb63b0d',

'src/third_party/dart/third_party/pkg/test':
Var('dart_git') + '/test.git@7756833000d671d4540b37ef04acd4b9e716026f',

'src/third_party/dart/third_party/pkg/test_reflective_loader':
Var('dart_git') + '/test_reflective_loader.git@ef934b7a894d78601ba67d8f6207bd4505690456',
Var('dart_git') + '/test_reflective_loader.git@52b6753852661787208e003f9716b079026c7ac7',

'src/third_party/dart/third_party/pkg/typed_data':
Var('dart_git') + '/typed_data.git@1e838b8ec85699b5b99e793d004ae315e72fcbc0',
Expand All @@ -336,7 +340,7 @@ deps = {
Var('dart_git') + '/external/github.com/google/webkit_inspection_protocol.dart.git' + '@' + Var('dart_webkit_inspection_protocol_rev'),

'src/third_party/dart/third_party/pkg/yaml':
Var('dart_git') + '/yaml.git@fda5b15692ccfa0feb7793a27fe3829b3d0f77fa',
Var('dart_git') + '/yaml.git@f6992752da8883a4bd9b036063371dca552848cc',

'src/third_party/dart/third_party/pkg/yaml_edit':
Var('dart_git') + '/yaml_edit.git' + '@' + Var('dart_yaml_edit_rev'),
Expand Down Expand Up @@ -692,7 +696,7 @@ deps = {
'packages': [
{
'package': 'fuchsia/sdk/core/mac-amd64',
'version': 'SVtX810D2U_ZgBcpxIHbGCVzRKBhya-WKNtZsMDQqIUC'
'version': 'mwKdD1jX_KVP1U76zmZ_Ori2TmrLCU8_1j0OGYy1CNEC'
}
],
'condition': 'host_os == "mac" and not download_fuchsia_sdk',
Expand All @@ -702,7 +706,7 @@ deps = {
'packages': [
{
'package': 'fuchsia/sdk/core/linux-amd64',
'version': 'JzUXGxIUUNgr8qJUxGxh_UnhZqEJmQC4TkW8zJPSh9MC'
'version': '5Xd8MJTM-pWPWCgUaaVSPeXe3pAu-xZ-_VO3NgARPDEC'
}
],
'condition': 'host_os == "linux" and not download_fuchsia_sdk',
Expand Down
23 changes: 15 additions & 8 deletions ci/bin/format.dart
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ FormatCheck nameToFormatCheck(String name) {
String formatCheckToName(FormatCheck check) {
switch (check) {
case FormatCheck.clang:
return 'C++/ObjC';
return 'C++/ObjC/Shader';
case FormatCheck.gn:
return 'GN';
case FormatCheck.java:
Expand Down Expand Up @@ -301,7 +301,7 @@ abstract class FormatChecker {
}
}

/// Checks and formats C++/ObjC files using clang-format.
/// Checks and formats C++/ObjC/Shader files using clang-format.
class ClangFormatChecker extends FormatChecker {
ClangFormatChecker({
ProcessManager processManager = const LocalProcessManager(),
Expand Down Expand Up @@ -350,7 +350,7 @@ class ClangFormatChecker extends FormatChecker {

@override
Future<bool> fixFormatting() async {
message('Fixing C++/ObjC formatting...');
message('Fixing C++/ObjC/Shader formatting...');
final List<String> failures = await _getCFormatFailures(fixing: true);
if (failures.isEmpty) {
return true;
Expand All @@ -365,7 +365,7 @@ class ClangFormatChecker extends FormatChecker {
}

Future<List<String>> _getCFormatFailures({bool fixing = false}) async {
message('Checking C++/ObjC formatting...');
message('Checking C++/ObjC/Shader formatting...');
const List<String> clangFiletypes = <String>[
'*.c',
'*.cc',
Expand All @@ -374,10 +374,17 @@ class ClangFormatChecker extends FormatChecker {
'*.h',
'*.m',
'*.mm',
'*.glsl',
'*.hlsl',
'*.comp',
'*.tese',
'*.tesc',
'*.vert',
'*.frag',
];
final List<String> files = await getFileList(clangFiletypes);
if (files.isEmpty) {
message('No C++/ObjC files with changes, skipping C++/ObjC format check.');
message('No C++/ObjC/Shader files with changes, skipping C++/ObjC/Shader format check.');
return <String>[];
}
if (verbose) {
Expand Down Expand Up @@ -416,10 +423,10 @@ class ClangFormatChecker extends FormatChecker {
if (failed.isNotEmpty) {
final bool plural = failed.length > 1;
if (fixing) {
message('Fixing ${failed.length} C++/ObjC file${plural ? 's' : ''}'
message('Fixing ${failed.length} C++/ObjC/Shader file${plural ? 's' : ''}'
' which ${plural ? 'were' : 'was'} formatted incorrectly.');
} else {
error('Found ${failed.length} C++/ObjC file${plural ? 's' : ''}'
error('Found ${failed.length} C++/ObjC/Shader file${plural ? 's' : ''}'
' which ${plural ? 'were' : 'was'} formatted incorrectly.');
stdout.writeln('To fix, run:');
stdout.writeln();
Expand All @@ -431,7 +438,7 @@ class ClangFormatChecker extends FormatChecker {
stdout.writeln();
}
} else {
message('Completed checking ${diffJobs.length} C++/ObjC files with no formatting problems.');
message('Completed checking ${diffJobs.length} C++/ObjC/Shader files with no formatting problems.');
}
return failed.map<String>((WorkerJob job) {
return job.result.stdout;
Expand Down
2 changes: 1 addition & 1 deletion ci/licenses.sh
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ function verify_licenses() (

local actualLicenseCount
actualLicenseCount="$(tail -n 1 flutter/ci/licenses_golden/licenses_flutter | tr -dc '0-9')"
local expectedLicenseCount=16 # When changing this number: Update the error message below as well describing all expected license types.
local expectedLicenseCount=17 # When changing this number: Update the error message below as well describing all expected license types.

if [[ $actualLicenseCount -ne $expectedLicenseCount ]]; then
echo "=============================== ERROR ==============================="
Expand Down
Loading