[obsolete] Call focus on input after detecting a tap #37732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
…... (flutter#37729) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Now that OpenGL support has been removed from the macOS embedder, we merge FlutterRenderBackingStore and its only implementing subclass, FlutterMetalRenderBackingStore, and similarly FlutterRenderBackingStoreProvider and its only implementing subclass FlutterMetalRenderBackingStoreProvider. Issue: flutter/flutter#108304 Issue: flutter/flutter#114445
Removes a few unncessary references to Metal in the macOS embedder. Now that Metal is the only supported rendering implementation for the macOS embedder, specifying a class as a Metal variant is redundant. Issue: flutter/flutter#108304 Issue: flutter/flutter#114445
* only clip when necessary tests fix tests format review fix add scenario tset more scenario tests add docs and comments use offset.zero * remove mistakenly checked-in code
…7739) https://skia.googlesource.com/skia.git/+log/55f654bf5cff..9d56e506b4df 2022-11-18 herb@google.com Remove missplaced attribute 2022-11-18 kjlubick@google.com Reland "[includes] Enforce IWYU on GrCaps" 2022-11-17 johnstiles@google.com Add immediate_i and immediate_u to the RP builder. 2022-11-17 johnstiles@google.com Remove [[unlikely]] attribute. 2022-11-17 herb@google.com Fix Forward: export sk_report_container_overflow_and_die 2022-11-17 brianosman@google.com Revert "Remove legacy shader context support from SkPictureShader" 2022-11-17 borenet@google.com [infra] Add kubeval CIPD package 2022-11-17 johnstiles@google.com Remove FunctionSlots struct and its additional mask field. 2022-11-17 johnstiles@google.com Add a stack for condition masks. 2022-11-17 johnstiles@google.com Revert "[includes] Enforce IWYU on GrCaps" 2022-11-17 johnstiles@google.com Add load_unmasked op. 2022-11-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f1b1fd3fc034 to e1ca9c6a1169 (7 revisions) 2022-11-17 kjlubick@google.com [includes] Enforce IWYU on GrCaps If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC aaclarke@google.com,tdenniston@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) https://skia.googlesource.com/skia.git/+log/9d56e506b4df..d693b4b9fe5e 2022-11-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 9f67b1ec8dca to 5f68de3ef7cd 2022-11-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 03e69803f4ca to 386ef2eefe63 (7 revisions) 2022-11-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from dd35c62aef80 to 6a259c87ef52 (1 revision) 2022-11-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 4d31683e4bbf to 9f67b1ec8dca (2 revisions) 2022-11-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from ae483daa63a5 to e956a04dafc3 (22 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC aaclarke@google.com,tdenniston@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter#37742) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
https://skia.googlesource.com/skia.git/+log/d693b4b9fe5e..ab054a88d7c7 2022-11-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e1ca9c6a1169 to 07bbe62a610d (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC aaclarke@google.com,tdenniston@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) https://skia.googlesource.com/skia.git/+log/ab054a88d7c7..345bceacd298 2022-11-18 kjlubick@google.com [includes] Enforce IWYU on GrSurfaceProxyView 2022-11-18 kjlubick@google.com [includes] Enforce IWYU on GrRenderTargetProxy 2022-11-18 kjlubick@google.com [includes] Enforce IWYU on GrSurfaceProxy If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC aaclarke@google.com,tdenniston@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…... (flutter#37747) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Upload to staging buffer and then copy the buffer to texture, this ensure that tiling is respected and the image is shown as intended, without this change the image would be shown as random chunks.
) https://skia.googlesource.com/skia.git/+log/345bceacd298..5270b1d26b5f 2022-11-18 borenet@google.com [infra] Add yq asset 2022-11-18 kjlubick@google.com [infra] Add fetch-ninja script 2022-11-18 kjlubick@google.com [infra] Get ninja from CIPD via DEPS 2022-11-18 kjlubick@google.com [includes] Enforce IWYU on GrTextureProxy If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC aaclarke@google.com,tdenniston@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) https://skia.googlesource.com/skia.git/+log/5270b1d26b5f..cf967e6b1c00 2022-11-18 bungeman@google.com Fix SkTFitsIn enum signedness checks 2022-11-18 kjlubick@google.com [infra] Make fetch-ninja idempotent 2022-11-18 jsimmons@google.com Remove unused TextLine::metricsWithoutMultiplier method 2022-11-18 jsimmons@google.com Fix typos in TextLine::shapeEllipsis 2022-11-18 bsalomon@google.com Convert Samples from other directories to Slides If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC aaclarke@google.com,tdenniston@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This patch also eliminates some extraneous tracing that is happening every frame. It is possible to get the same trace calls by enabling the API stream if needed. Also refactors the NotifyIdle callsites to just always work in TimeDeltas rather than converting back and forth between them and TimePoints, which I think reads more clearly.
…utter#37654) * [Impeller] use uniform array for more efficient small gradients * ++ * Make this work on Android * ++ * ++ * ++ * compiler support and basic feature detection * ++ * ++ * rename to ssbo_fill, move to context * ++ * ++ * ++ * tests * ++ * ++
) https://skia.googlesource.com/skia.git/+log/cf967e6b1c00..f1f59de17204 2022-11-18 jvanverth@google.com [graphite] Fix SDF text removal 2022-11-18 johnstiles@google.com Add store_masked to RasterPipeline and the builder. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC aaclarke@google.com,tdenniston@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#37735) * Made FlutterTextField that outlive FlutterTextPlatformNode not crash. * added test
Previously there were two conventions for test filenames in the macOS embedder: some ended in Unittests.mm and others eneded in Test.mm. This applies a consistent naming convention, which is also consistent with the iOS and common Darwin tests. Stock C++ unittests should continue to use the _unittests.cc convention.
https://skia.googlesource.com/skia.git/+log/f1f59de17204..12f01bc5b57e 2022-11-18 fmalita@chromium.org [skottie] Relocate shaper tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC aaclarke@google.com,tdenniston@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
* remove cq * bringup: false
) https://skia.googlesource.com/skia.git/+log/12f01bc5b57e..c53d8cf5b823 2022-11-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 07bbe62a610d to 3314dca93077 (2 revisions) 2022-11-18 jmbetancourt@google.com strip headers from list of src files in Android.bp 2022-11-18 tdenniston@google.com Revert "Add store_masked to RasterPipeline and the builder." 2022-11-18 jmbetancourt@google.com build skottie for all platforms in Android.bp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC aaclarke@google.com,tdenniston@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) https://skia.googlesource.com/skia.git/+log/3b2d9e4bf668..3bd2fe46f6d2 2022-11-22 armansito@google.com [sksl] "workgroup" instead of "threadgroup" 2022-11-22 penghuang@chromium.org [graphite] Refactor DrawBufferManager to share code for allocating buffers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC jmbetancourt@google.com,kaushikiska@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) https://skia.googlesource.com/skia.git/+log/3bd2fe46f6d2..c098e3c5d932 2022-11-22 brianosman@google.com Fix incorrect comments on SkGradientShader factories 2022-11-22 jcgregorio@google.com Add Pixel7 jobs. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC jmbetancourt@google.com,kaushikiska@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
* Turn on objc-* clang-tidy checks * turn off objc-nsinvocation-argument-lifetime
* Start * Add missing line * Order * Clean up includes * Feedback * Tweak
https://dart.googlesource.com/sdk.git/+log/27c45cd51796..d2766b385c2a 2022-11-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 2.19.0-421.0.dev 2022-11-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 2.19.0-420.0.dev 2022-11-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 2.19.0-419.0.dev 2022-11-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 2.19.0-418.0.dev 2022-11-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 2.19.0-417.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC dart-vm-team@google.com,kaushikiska@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…oiceover-keyboard
flutter-dashboard
bot
added
embedder
8 tasks
nbayati
changed the title
|
This PR is obsolete. please refer to #37863. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-launch Checklist
///).