Fix premature LayerStateStack layer culling #38159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flar
added a commit
to flar/engine
that referenced
this pull request
Dec 9, 2022
* remove premature opacity culling * remove premature clip culling
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 9, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 9, 2022
…116811) * 2121d8187 [web] Use js_util.promiseToFuture with CanvasKitInit() (flutter/engine#38128) * a259613ab Fix premature LayerStateStack layer culling (flutter/engine#38159)
loic-sharma
pushed a commit
to loic-sharma/flutter-engine
that referenced
this pull request
Dec 16, 2022
* remove premature opacity culling * remove premature clip culling
itsjustkevin
pushed a commit
that referenced
this pull request
Dec 16, 2022
* Fix premature LayerStateStack layer culling (#38159) * remove premature opacity culling * remove premature clip culling * empty
loic-sharma
pushed a commit
to loic-sharma/flutter-engine
that referenced
this pull request
Jan 3, 2023
* remove premature opacity culling * remove premature clip culling
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#116811) * 2121d8187 [web] Use js_util.promiseToFuture with CanvasKitInit() (flutter/engine#38128) * a259613ab Fix premature LayerStateStack layer culling (flutter/engine#38159)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LayerStateStack introduced some aggressive clip and opacity culling to the Paint methods of some layers. Unfortunately, PlatformViews require that their Paint method is called if their Preroll method is called. Since we Preroll all layers regardless of culling, then we must Paint all PlatformViewLayers regardless of culling. The culling introduced by the LayerStateStack did not check if there was a PlatformView in the subtree before returning early, so this PR eliminates those optimizations.