Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[linux] Allow overriding asset, ICU data path #38296

Merged
merged 1 commit into from Dec 15, 2022
Merged

[linux] Allow overriding asset, ICU data path #38296

merged 1 commit into from Dec 15, 2022

Conversation

cbracken
Copy link
Member

@cbracken cbracken commented Dec 14, 2022 •
edited

Support setting a custom asset directory and ICU data path.

Fixes: flutter/flutter#117103
Issue: flutter/flutter#117102

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken
[linux] Allow overriding asset, ICU data path
9672466 
Support setting a custom asset directory and ICU data path.

Fixes: flutter/flutter#117103
@cbracken cbracken merged commit e28b26e into flutter:main Dec 15, 2022
@cbracken cbracken deleted the set-linux-asset-path branch December 15, 2022 16:25
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2022
@engine-flutter-autoroll
e28b26e1d [linux] Allow overriding asset, ICU data path (flutter/engi…
4be60e0 
…ne#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2022
@engine-flutter-autoroll
e28b26e1d [linux] Allow overriding asset, ICU data path (flutter/engi…
72c7441 
…ne#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2022
@engine-flutter-autoroll
e28b26e1d [linux] Allow overriding asset, ICU data path (flutter/engi…
ff072e7 
…ne#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2022
@engine-flutter-autoroll
e28b26e1d [linux] Allow overriding asset, ICU data path (flutter/engi…
54c36f6 
…ne#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2022
@engine-flutter-autoroll
e28b26e1d [linux] Allow overriding asset, ICU data path (flutter/engi…
1feeae7 
…ne#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2022
@engine-flutter-autoroll
e28b26e1d [linux] Allow overriding asset, ICU data path (flutter/engi…
c778345 
…ne#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2022
@engine-flutter-autoroll
e28b26e1d [linux] Allow overriding asset, ICU data path (flutter/engi…
980da6c 
…ne#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2022
@engine-flutter-autoroll
e28b26e1d [linux] Allow overriding asset, ICU data path (flutter/engi…
8a0d110 
…ne#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2022
@engine-flutter-autoroll
e28b26e1d [linux] Allow overriding asset, ICU data path (flutter/engi…
d0b92ff 
…ne#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
e28b26e1d [linux] Allow overriding asset, ICU data path (flutter/engi…
b93abf2 
…ne#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
e28b26e1d [linux] Allow overriding asset, ICU data path (flutter/engi…
1401139 
…ne#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
e28b26e1d [linux] Allow overriding asset, ICU data path (flutter/engi…
78bf008 
…ne#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
e28b26e1d [linux] Allow overriding asset, ICU data path (flutter/engi…
ebaaf6a 
…ne#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
e28b26e1d [linux] Allow overriding asset, ICU data path (flutter/engi…
6bfe256 
…ne#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
e28b26e1d [linux] Allow overriding asset, ICU data path (flutter/engi…
de7c712 
…ne#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
e28b26e1d [linux] Allow overriding asset, ICU data path (flutter/engi…
f151c7d 
…ne#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
e28b26e1d [linux] Allow overriding asset, ICU data path (flutter/engi…
ea109cb 
…ne#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
e28b26e1d [linux] Allow overriding asset, ICU data path (flutter/engi…
c07aeb0 
…ne#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
e28b26e1d [linux] Allow overriding asset, ICU data path (flutter/engi…
4bcfe37 
…ne#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
e28b26e1d [linux] Allow overriding asset, ICU data path (flutter/engi…
49d862c 
…ne#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
e28b26e1d [linux] Allow overriding asset, ICU data path (flutter/engi…
b866d9a 
…ne#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
e28b26e1d [linux] Allow overriding asset, ICU data path (flutter/engi…
9732934 
…ne#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
e28b26e1d [linux] Allow overriding asset, ICU data path (flutter/engi…
68dc5bf 
…ne#38296)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
Roll Flutter Engine from 29196519c124 to d91e20879a67 (29 revisions) (#…
5018a6c 
…117242)

* e28b26e1d [linux] Allow overriding asset, ICU data path (flutter/engine#38296)

* 35bdb8bfc Roll Skia from 9f728d78f10d to f549128104ba (1 revision) (flutter/engine#38319)

* 97e246cb5 Roll Dart SDK from 358d0d1aa3e7 to 1dd5b1bf1099 (7 revisions) (flutter/engine#38320)

* d9580a5e7 Migrate iOS text input plugin to use ARC (flutter/engine#38179)

* c9e9fa5a9 Update web_sdk -> package test dependency to get updated package matcher (flutter/engine#38323)

* a7ec07f13 [fuchsia] Manually roll Fuchsia Linux SDK. (flutter/engine#38324)

* 61e95bacb Remove doc reference to the compute method (flutter/engine#38246)

* 353d6949e make sure CanvasRecorder updates clip bounds methods (flutter/engine#38325)

* 47a358c5e Started using FlutterEngineGroups by default on Android  (flutter/engine#37822)

* 7d8e10652 Bump github/codeql-action from 2.1.35 to 2.1.36 (flutter/engine#38210)

* 8915b81d4 Update buildroot to b2ab6e1908b3eb2. (flutter/engine#38329)

* 4fe620643 Revert "Roll Dart SDK from 358d0d1aa3e7 to 1dd5b1bf1099 (7 revisions) (#38320)" (flutter/engine#38331)

* 2ff490c1e Roll Skia from f549128104ba to 5e69caecd166 (11 revisions) (flutter/engine#38333)

* 22251857f Add missing include to FlutterThreadSynchronizer (flutter/engine#38337)

* 467cfd7ef Roll Fuchsia Mac SDK from VEOIaacOA75U7PYyz... to KtItDj-MERuua77aS... (flutter/engine#38339)

* 010f4ee7a Roll Fuchsia Linux SDK from zwfwHRSLdmV61hYqe... to urDNtEiHFAcBBhYe0... (flutter/engine#38340)

* 773b43571 Sped up reading with FlutterStandardCodec. (flutter/engine#38327)

* 70439f606 Roll Skia from 5e69caecd166 to 62f22c9c7d67 (3 revisions) (flutter/engine#38341)

* bc1647f0d Roll the test package used by Web in preparation for a Dart 3 SDK roll (flutter/engine#38342)

* cac228aff Roll Dart SDK from 358d0d1aa3e7 to 7b4d4ec3cad1 (14 revisions) (flutter/engine#38344)

* 13ae6eb75 Revert "Started using FlutterEngineGroups by default on Android  (#37822)" (flutter/engine#38351)

* ed8063861 Add an explicit constraint on the matcher package version to ensure Dart 3 compatibility (flutter/engine#38352)

* dcafebf44 Roll Skia from 62f22c9c7d67 to 1b1f53d77ced (1 revision) (flutter/engine#38343)

* 6f6158580 Roll Fuchsia Mac SDK from KtItDj-MERuua77aS... to bn5VF1-xDf-wKjIw8... (flutter/engine#38348)

* 0c00bc0a9 Remove 30fps cap from playgrounds (flutter/engine#38347)

* 38340bb57 [Impeller] Fix SceneC crash for nodes with children (flutter/engine#38346)

* 3a6b3f986 Roll Fuchsia Linux SDK from urDNtEiHFAcBBhYe0... to H6B0UgW07fc1nBtnc... (flutter/engine#38357)

* 81b453535 Roll Skia from 1b1f53d77ced to 7b0a9d9a3008 (8 revisions) (flutter/engine#38358)

* d91e20879 Port touch-based tests from embedder integration test (flutter/engine#38234)
loic-sharma pushed a commit to loic-sharma/flutter-engine that referenced this pull request Jan 3, 2023
@cbracken @loic-sharma
[linux] Allow overriding asset, ICU data path (flutter#38296)
881c130 
Support setting a custom asset directory and ICU data path.

Fixes: flutter/flutter#117103
Issue: flutter/flutter#117102
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@engine-flutter-autoroll @gspencergoog
Roll Flutter Engine from 29196519c124 to d91e20879a67 (29 revisions) (f…
1ad4f5b 
…lutter#117242)

* e28b26e1d [linux] Allow overriding asset, ICU data path (flutter/engine#38296)

* 35bdb8bfc Roll Skia from 9f728d78f10d to f549128104ba (1 revision) (flutter/engine#38319)

* 97e246cb5 Roll Dart SDK from 358d0d1aa3e7 to 1dd5b1bf1099 (7 revisions) (flutter/engine#38320)

* d9580a5e7 Migrate iOS text input plugin to use ARC (flutter/engine#38179)

* c9e9fa5a9 Update web_sdk -> package test dependency to get updated package matcher (flutter/engine#38323)

* a7ec07f13 [fuchsia] Manually roll Fuchsia Linux SDK. (flutter/engine#38324)

* 61e95bacb Remove doc reference to the compute method (flutter/engine#38246)

* 353d6949e make sure CanvasRecorder updates clip bounds methods (flutter/engine#38325)

* 47a358c5e Started using FlutterEngineGroups by default on Android  (flutter/engine#37822)

* 7d8e10652 Bump github/codeql-action from 2.1.35 to 2.1.36 (flutter/engine#38210)

* 8915b81d4 Update buildroot to b2ab6e1908b3eb2. (flutter/engine#38329)

* 4fe620643 Revert "Roll Dart SDK from 358d0d1aa3e7 to 1dd5b1bf1099 (7 revisions) (flutter#38320)" (flutter/engine#38331)

* 2ff490c1e Roll Skia from f549128104ba to 5e69caecd166 (11 revisions) (flutter/engine#38333)

* 22251857f Add missing include to FlutterThreadSynchronizer (flutter/engine#38337)

* 467cfd7ef Roll Fuchsia Mac SDK from VEOIaacOA75U7PYyz... to KtItDj-MERuua77aS... (flutter/engine#38339)

* 010f4ee7a Roll Fuchsia Linux SDK from zwfwHRSLdmV61hYqe... to urDNtEiHFAcBBhYe0... (flutter/engine#38340)

* 773b43571 Sped up reading with FlutterStandardCodec. (flutter/engine#38327)

* 70439f606 Roll Skia from 5e69caecd166 to 62f22c9c7d67 (3 revisions) (flutter/engine#38341)

* bc1647f0d Roll the test package used by Web in preparation for a Dart 3 SDK roll (flutter/engine#38342)

* cac228aff Roll Dart SDK from 358d0d1aa3e7 to 7b4d4ec3cad1 (14 revisions) (flutter/engine#38344)

* 13ae6eb75 Revert "Started using FlutterEngineGroups by default on Android  (flutter#37822)" (flutter/engine#38351)

* ed8063861 Add an explicit constraint on the matcher package version to ensure Dart 3 compatibility (flutter/engine#38352)

* dcafebf44 Roll Skia from 62f22c9c7d67 to 1b1f53d77ced (1 revision) (flutter/engine#38343)

* 6f6158580 Roll Fuchsia Mac SDK from KtItDj-MERuua77aS... to bn5VF1-xDf-wKjIw8... (flutter/engine#38348)

* 0c00bc0a9 Remove 30fps cap from playgrounds (flutter/engine#38347)

* 38340bb57 [Impeller] Fix SceneC crash for nodes with children (flutter/engine#38346)

* 3a6b3f986 Roll Fuchsia Linux SDK from urDNtEiHFAcBBhYe0... to H6B0UgW07fc1nBtnc... (flutter/engine#38357)

* 81b453535 Roll Skia from 1b1f53d77ced to 7b0a9d9a3008 (8 revisions) (flutter/engine#38358)

* d91e20879 Port touch-based tests from embedder integration test (flutter/engine#38234)
@fertrig fertrig mentioned this pull request Jan 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loic-sharma loic-sharma loic-sharma approved these changes

@stuartmorgan stuartmorgan Awaiting requested review from stuartmorgan

@robert-ancell robert-ancell Awaiting requested review from robert-ancell

Assignees
No one assigned
Labels
platform-linux
Projects
None yet
Milestone
No milestone
2 participants
@cbracken @loic-sharma