[Impeller] Fix SceneC crash for nodes with children #38346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zanderso
approved these changes
Dec 16, 2022
chinmaygarde
approved these changes
Dec 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 16, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 16, 2022
…117242) * e28b26e1d [linux] Allow overriding asset, ICU data path (flutter/engine#38296) * 35bdb8bfc Roll Skia from 9f728d78f10d to f549128104ba (1 revision) (flutter/engine#38319) * 97e246cb5 Roll Dart SDK from 358d0d1aa3e7 to 1dd5b1bf1099 (7 revisions) (flutter/engine#38320) * d9580a5e7 Migrate iOS text input plugin to use ARC (flutter/engine#38179) * c9e9fa5a9 Update web_sdk -> package test dependency to get updated package matcher (flutter/engine#38323) * a7ec07f13 [fuchsia] Manually roll Fuchsia Linux SDK. (flutter/engine#38324) * 61e95bacb Remove doc reference to the compute method (flutter/engine#38246) * 353d6949e make sure CanvasRecorder updates clip bounds methods (flutter/engine#38325) * 47a358c5e Started using FlutterEngineGroups by default on Android (flutter/engine#37822) * 7d8e10652 Bump github/codeql-action from 2.1.35 to 2.1.36 (flutter/engine#38210) * 8915b81d4 Update buildroot to b2ab6e1908b3eb2. (flutter/engine#38329) * 4fe620643 Revert "Roll Dart SDK from 358d0d1aa3e7 to 1dd5b1bf1099 (7 revisions) (#38320)" (flutter/engine#38331) * 2ff490c1e Roll Skia from f549128104ba to 5e69caecd166 (11 revisions) (flutter/engine#38333) * 22251857f Add missing include to FlutterThreadSynchronizer (flutter/engine#38337) * 467cfd7ef Roll Fuchsia Mac SDK from VEOIaacOA75U7PYyz... to KtItDj-MERuua77aS... (flutter/engine#38339) * 010f4ee7a Roll Fuchsia Linux SDK from zwfwHRSLdmV61hYqe... to urDNtEiHFAcBBhYe0... (flutter/engine#38340) * 773b43571 Sped up reading with FlutterStandardCodec. (flutter/engine#38327) * 70439f606 Roll Skia from 5e69caecd166 to 62f22c9c7d67 (3 revisions) (flutter/engine#38341) * bc1647f0d Roll the test package used by Web in preparation for a Dart 3 SDK roll (flutter/engine#38342) * cac228aff Roll Dart SDK from 358d0d1aa3e7 to 7b4d4ec3cad1 (14 revisions) (flutter/engine#38344) * 13ae6eb75 Revert "Started using FlutterEngineGroups by default on Android (#37822)" (flutter/engine#38351) * ed8063861 Add an explicit constraint on the matcher package version to ensure Dart 3 compatibility (flutter/engine#38352) * dcafebf44 Roll Skia from 62f22c9c7d67 to 1b1f53d77ced (1 revision) (flutter/engine#38343) * 6f6158580 Roll Fuchsia Mac SDK from KtItDj-MERuua77aS... to bn5VF1-xDf-wKjIw8... (flutter/engine#38348) * 0c00bc0a9 Remove 30fps cap from playgrounds (flutter/engine#38347) * 38340bb57 [Impeller] Fix SceneC crash for nodes with children (flutter/engine#38346) * 3a6b3f986 Roll Fuchsia Linux SDK from urDNtEiHFAcBBhYe0... to H6B0UgW07fc1nBtnc... (flutter/engine#38357) * 81b453535 Roll Skia from 1b1f53d77ced to 7b0a9d9a3008 (8 revisions) (flutter/engine#38358) * d91e20879 Port touch-based tests from embedder integration test (flutter/engine#38234)
loic-sharma
pushed a commit
to loic-sharma/flutter-engine
that referenced
this pull request
Jan 3, 2023
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#117242) * e28b26e1d [linux] Allow overriding asset, ICU data path (flutter/engine#38296) * 35bdb8bfc Roll Skia from 9f728d78f10d to f549128104ba (1 revision) (flutter/engine#38319) * 97e246cb5 Roll Dart SDK from 358d0d1aa3e7 to 1dd5b1bf1099 (7 revisions) (flutter/engine#38320) * d9580a5e7 Migrate iOS text input plugin to use ARC (flutter/engine#38179) * c9e9fa5a9 Update web_sdk -> package test dependency to get updated package matcher (flutter/engine#38323) * a7ec07f13 [fuchsia] Manually roll Fuchsia Linux SDK. (flutter/engine#38324) * 61e95bacb Remove doc reference to the compute method (flutter/engine#38246) * 353d6949e make sure CanvasRecorder updates clip bounds methods (flutter/engine#38325) * 47a358c5e Started using FlutterEngineGroups by default on Android (flutter/engine#37822) * 7d8e10652 Bump github/codeql-action from 2.1.35 to 2.1.36 (flutter/engine#38210) * 8915b81d4 Update buildroot to b2ab6e1908b3eb2. (flutter/engine#38329) * 4fe620643 Revert "Roll Dart SDK from 358d0d1aa3e7 to 1dd5b1bf1099 (7 revisions) (flutter#38320)" (flutter/engine#38331) * 2ff490c1e Roll Skia from f549128104ba to 5e69caecd166 (11 revisions) (flutter/engine#38333) * 22251857f Add missing include to FlutterThreadSynchronizer (flutter/engine#38337) * 467cfd7ef Roll Fuchsia Mac SDK from VEOIaacOA75U7PYyz... to KtItDj-MERuua77aS... (flutter/engine#38339) * 010f4ee7a Roll Fuchsia Linux SDK from zwfwHRSLdmV61hYqe... to urDNtEiHFAcBBhYe0... (flutter/engine#38340) * 773b43571 Sped up reading with FlutterStandardCodec. (flutter/engine#38327) * 70439f606 Roll Skia from 5e69caecd166 to 62f22c9c7d67 (3 revisions) (flutter/engine#38341) * bc1647f0d Roll the test package used by Web in preparation for a Dart 3 SDK roll (flutter/engine#38342) * cac228aff Roll Dart SDK from 358d0d1aa3e7 to 7b4d4ec3cad1 (14 revisions) (flutter/engine#38344) * 13ae6eb75 Revert "Started using FlutterEngineGroups by default on Android (flutter#37822)" (flutter/engine#38351) * ed8063861 Add an explicit constraint on the matcher package version to ensure Dart 3 compatibility (flutter/engine#38352) * dcafebf44 Roll Skia from 62f22c9c7d67 to 1b1f53d77ced (1 revision) (flutter/engine#38343) * 6f6158580 Roll Fuchsia Mac SDK from KtItDj-MERuua77aS... to bn5VF1-xDf-wKjIw8... (flutter/engine#38348) * 0c00bc0a9 Remove 30fps cap from playgrounds (flutter/engine#38347) * 38340bb57 [Impeller] Fix SceneC crash for nodes with children (flutter/engine#38346) * 3a6b3f986 Roll Fuchsia Linux SDK from urDNtEiHFAcBBhYe0... to H6B0UgW07fc1nBtnc... (flutter/engine#38357) * 81b453535 Roll Skia from 1b1f53d77ced to 7b0a9d9a3008 (8 revisions) (flutter/engine#38358) * d91e20879 Port touch-based tests from embedder integration test (flutter/engine#38234)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a simple test mesh containing two triangles with different materials, and two parented bones weighted to the triangles. This is useful for testing many things.