[Impeller] Use the start/end tangent of contours to compute stroke contour cap normals #39124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 26, 2023
zanderso
pushed a commit
to zanderso/engine
that referenced
this pull request
Jan 26, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 26, 2023
…119218) * c068a3675 [Impeller] Use analytical normals for stroke caps (flutter/engine#39124) * 68912346c Roll Dart SDK from de14a48187ce to d9151e59f70b (6 revisions) (flutter/engine#39146) * 285f3311b Roll Clang from a93d03310e2c to 20d06c833d83 (flutter/engine#39152) * ab2ccd5a6 Roll Dart SDK from d9151e59f70b to f61211592196 (3 revisions) (flutter/engine#39154) * 04f22beeb Roll Skia from 393fb1ec80f4 to 3d0e2ad41911 (6 revisions) (flutter/engine#39153)
XilaiZhang
pushed a commit
that referenced
this pull request
Jan 31, 2023
This was referenced Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves flutter/flutter#118945.
Cap::kButtcap, since it may no longer align perfectly with the last line segment direction.Cap::kButt.Before:
Screen.Recording.2023-01-24.at.11.31.35.PM.mov
After:
Screen.Recording.2023-01-25.at.2.19.38.AM.mov