Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Impeller] Ignore the mask filter when saving layer #39583

Merged
merged 2 commits into from Feb 15, 2023

Conversation

ColdPaleLight
Copy link
Member

According to Skia's documentation and implementation, mask filters are ignored for saved layers. So I guess Impeller needs to be consistent with it.

https://github.com/google/skia/blob/main/include/core/SkCanvas.h#L604-L605
https://github.com/google/skia/blob/main/src/core/SkCanvas.cpp#L1114

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@chinmaygarde
Copy link
Member

IIRC @bdero added that initially. So he may have additional context. Also cc @jonahwilliams. But otherwise LGTM to match Skia behavior. Is there a reduced test case?

Copy link
Member

@bdero bdero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ColdPaleLight ColdPaleLight added autosubmit Merge PR when tree becomes green via auto submit App and removed needs tests labels Feb 15, 2023
@auto-submit auto-submit bot merged commit 414538f into flutter:main Feb 15, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 15, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 15, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 15, 2023
…120781)

* 414538fc6 [Impeller] Ignore the mask filter when saving layer (flutter/engine#39583)

* ec70b5aa9 Roll Fuchsia Linux SDK from A15Lg2MzGSkbj33mo... to ejOvPyZ4UL2DoQhn6... (flutter/engine#39645)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
No open projects
Archived in project
3 participants