Add support for double tap action from Apple Pencil 2 #39637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
embedder
8 tasks
hellohuanlin
approved these changes
Feb 15, 2023
jmagman
approved these changes
Feb 15, 2023
LouiseHsu
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 16, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 16, 2023
…120845) * b310be5ce Revert "Revert "Add support for double tap action from Apple Pencil 2 (#39267)" (#39607)" (flutter/engine#39637) * 7c24f2ff3 Roll Dart SDK from 5d17a336bdfe to a594e34e85b6 (1 revision) (flutter/engine#39656) * fa1b2dd40 Roll Skia from 21627ff455d0 to bb3d8185f067 (13 revisions) (flutter/engine#39661) * 02a379db1 [web] consolidate network code into httpFetch (flutter/engine#39657)
LouiseHsu
added a commit
that referenced
this pull request
Apr 12, 2023
LouiseHsu
added a commit
that referenced
this pull request
Apr 13, 2023
Reverts #39637 Since this feature flutter/flutter#73172 has been scrapped for now, previous engine work should be reverted. Refer to [this design doc](https://docs.google.com/document/d/1r4P5r-jGt2Sjqro3ldCU2axUiHTpu3yhIycnI94OKQw/edit ) for more discussion and details.
zanderso
deleted the
revert-39607-revert-39267-louisehsu/pencil-double-tap
branch
zhongwuzw
pushed a commit
to zhongwuzw/engine
that referenced
this pull request
Apr 14, 2023
…er#41138) Reverts flutter#39637 Since this feature flutter/flutter#73172 has been scrapped for now, previous engine work should be reverted. Refer to [this design doc](https://docs.google.com/document/d/1r4P5r-jGt2Sjqro3ldCU2axUiHTpu3yhIycnI94OKQw/edit ) for more discussion and details.
8 tasks
LouiseHsu
added a commit
to flutter/flutter
that referenced
this pull request
Jun 14, 2023
This PR cleans up some prep that was added as part of #120731 which was done to unblock flutter/engine#39637 Since the work done in that PR was reverted, this should be removed. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #39607, which was a revert of #39267 because an introduction of a new PointerSignalKind broke a few framework tests.
This breakage is addressed in this framework prep PR which has merged. flutter/flutter#120731