[web] consolidate network code into httpFetch #39657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
mdebbar
requested changes
Feb 15, 2023
lib/web_ui/dev/test_platform.dart
Outdated
| Future<shelf.Response> _testPayloadGenerator(shelf.Request request) async { | ||
| if (!request.requestedUri.path.endsWith('/long_test_payload')) { | ||
| return shelf.Response.notFound( | ||
| 'This request is not handled by the screenshot handler'); |
mdebbar
approved these changes
Feb 15, 2023
yjbanov
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 16, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 16, 2023
…120845) * b310be5ce Revert "Revert "Add support for double tap action from Apple Pencil 2 (#39267)" (#39607)" (flutter/engine#39637) * 7c24f2ff3 Roll Dart SDK from 5d17a336bdfe to a594e34e85b6 (1 revision) (flutter/engine#39656) * fa1b2dd40 Roll Skia from 21627ff455d0 to bb3d8185f067 (13 revisions) (flutter/engine#39661) * 02a379db1 [web] consolidate network code into httpFetch (flutter/engine#39657)
ditman
reviewed
Feb 16, 2023
| @override | ||
| String toString() => 'Failed to load asset at "$url" ($httpStatus)'; | ||
| return (await response.payload.asByteBuffer()).asByteData(); | ||
| } | ||
| } | ||
|
|
||
| /// An asset manager that gives fake empty responses for assets. |
There was a problem hiding this comment.
Can the WebOnlyMockAssetManager class (and in general all the new Mock classes) be moved somewhere under test?
Comment on lines
+824
to
+825
| @visibleForTesting | ||
| Future<HttpFetchResponse> testOnlyHttpPost(String url, String data) async { |
There was a problem hiding this comment.
Is there any possibility that these test-only functions can be defined in test code only? That way you wouldn't need the @visibleForTesting annotation.
|
|
||
| /// Convenience function for making a fetch request and getting the data as a | ||
| /// [ByteBuffer], when the default error handling mechanism is sufficient. | ||
| Future<ByteBuffer> httpFetchByteBuffer(String url) async { |
There was a problem hiding this comment.
There's a fair amount of response.asUint8List uses, maybe it's worth to have a httpFetchUint8List method as well?
Comment on lines
+791
to
+796
| if (mockHttpFetchResponseFactory != null) { | ||
| return mockHttpFetchResponseFactory!(url); | ||
| } | ||
| try { | ||
| final _DomResponse domResponse = await _rawHttpGet(url); | ||
| return HttpFetchResponseImpl._(url, domResponse); |
There was a problem hiding this comment.
Since _DomResponse is a @staticInterop object, you may be able to simplify this a bunch by just making the mockHttpFetchResponseFactory return a
js_util.jsify({
// Something that resembles a _DomResponse
}) as _DomResponse;
(Or even create a real _DomResponse object with its constructor)
That would allow you to simplify the objects returned by fetch quite a bit, and also:
try {
_DomResponse response;
if (mockHttpFetchResponseFactory != null) {
response = await mockHttpFetchResponseFactory!(url);
} else {
response = await _rawHttpGet(url);
}
return HttpFetchResponseImpl._(url, domResponse);
} catch (...) {
//...
}
test what happens when the mockHttpRequestFactory throws.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate all of web engine HTTP code into a single
httpFetchfunction that provides a standard way for handling errors:httpFetchand a few specialize convenience functions around it for making HTTP calls.httpFetch(fonts, assets, network images,