Adds a Linux Fuchsia FEMU config that enables CSO #39718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godofredoc
reviewed
Feb 17, 2023
.ci.yaml
Outdated
| recipe: engine/femu_test | ||
| bringup: true | ||
| properties: | ||
| add_recipes_cq: "true" |
There was a problem hiding this comment.
False? as this build will be removing caches it will slow down recipes testing. Femu_test recipe is already being covered by the other builders.
There was a problem hiding this comment.
You tell me =) I have no idea what the flag is supposed to mean. I just copy-pasted from the other config.
| properties: | ||
| add_recipes_cq: "true" | ||
| build_fuchsia: "true" | ||
| fuchsia_ctl_version: version:0.0.27 |
There was a problem hiding this comment.
This is not needed, fuchsia_ctl was removed a few months ago.
There was a problem hiding this comment.
This is a copy paste from the other Fuchsia config. Let's remove in a separate cleanup.
.ci.yaml
Outdated
| clobber: "true" | ||
| emulator_arch: "x64" | ||
| enable_cso: "true" | ||
| timeout: 60 |
There was a problem hiding this comment.
Would 60 mins be enough? usually checking out all the repositories from a clean cache takes ~14 mins.
godofredoc
approved these changes
Feb 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 17, 2023
This was referenced Feb 17, 2023
Closed
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 17, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 17, 2023
…121004) * 6a2a46a28 Roll Dart SDK from 3ec7f1f92216 to 7642080abaf7 (2 revisions) (flutter/engine#39702) * f6bb7ae5f Roll Skia from d0df677ffd5e to ba60fed7f075 (6 revisions) (flutter/engine#39703) * 27696d2b7 Cached DisplayList opacity inheritance fix (flutter/engine#39690) * 1ae94738d Roll Dart SDK from 7642080abaf7 to 42829b6f80b1 (1 revision) (flutter/engine#39707) * 676201790 Roll Fuchsia Linux SDK from yT4JLKTCWWwbRwB0l... to tMm2Lzb-LE20Rxwm9... (flutter/engine#39709) * 26f1f251f Roll Skia from ba60fed7f075 to 5637cd56be32 (3 revisions) (flutter/engine#39710) * 4b0b8f053 Roll Dart SDK from 42829b6f80b1 to c7ec16304216 (1 revision) (flutter/engine#39711) * 1f7aad3a4 Roll Fuchsia Mac SDK from haDvcC5VzWVdQs9Rs... to _wymybZYKzX_3iFd6... (flutter/engine#39715) * 067369d22 Migrate skia png codec call to public interface (flutter/engine#39714) * 7e190a49c Roll Dart SDK from c7ec16304216 to 8a7dc36cadf6 (1 revision) (flutter/engine#39716) * 83a896250 Roll Skia from 5637cd56be32 to 02890036028e (2 revisions) (flutter/engine#39717) * 6d9387433 [linux] Eliminate mirrors support (flutter/engine#39701) * adc0ebd97 Adds a Linux Fuchsia FEMU config that enables CSO (flutter/engine#39718) * 0378b3406 [impeller] support generating mip-maps on Vulkan (flutter/engine#39689) * 5212ac439 [Impeller] Device default attachment pixel formats (flutter/engine#39655) * bd37a3992 Rollback Dart SDK to unblock the roller (flutter/engine#39722)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This configuration exposed Fuchsia issues that were not surfaced in any other environment when it was enabled prematurely last week. This change adds a
bringup: truebuilder for the new configuration. When it stabilizes,enable_csowill become the default, and thebringup: truebuilder can be deleted.enable_csowas added here https://flutter-review.git.corp.google.com/c/recipes/+/39400.