Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a Linux Fuchsia FEMU config that enables CSO #39718

Merged
merged 3 commits into from
Feb 17, 2023
Merged

Adds a Linux Fuchsia FEMU config that enables CSO #39718

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
040c340
Adds a Linux Fuchsia FEMU config that enables CSO
zanderso Feb 17, 2023
a335af8
Update .ci.yaml
zanderso Feb 17, 2023
b396163
Update .ci.yaml
zanderso Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,19 @@ targets:
emulator_arch: "x64"
timeout: 60

- name: Linux Fuchsia FEMU (cso)
recipe: engine/femu_test
bringup: true
properties:
add_recipes_cq: "true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

False? as this build will be removing caches it will slow down recipes testing. Femu_test recipe is already being covered by the other builders.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You tell me =) I have no idea what the flag is supposed to mean. I just copy-pasted from the other config.

build_fuchsia: "true"
fuchsia_ctl_version: version:0.0.27
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed, fuchsia_ctl was removed a few months ago.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a copy paste from the other Fuchsia config. Let's remove in a separate cleanup.

# ensure files from pre-production Fuchsia SDK tests are purged from cache
clobber: "true"
emulator_arch: "x64"
enable_cso: "true"
timeout: 60
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would 60 mins be enough? usually checking out all the repositories from a clean cache takes ~14 mins.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increased to 90


- name: Linux Fuchsia arm64 FEMU
recipe: engine/femu_test
bringup: true
Expand Down