[Impeller] Use blit for root pass copy #39933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdero
force-pushed
the
bdero/use-blit-pass
branch
from
9491bb5
to
1d5c261
Compare
Merged
bdero
force-pushed
the
bdero/use-blit-pass
branch
from
1d5c261
to
b826efc
Compare
chinmaygarde
requested changes
Feb 28, 2023
| @@ -514,7 +514,7 @@ TEST_P(RendererTest, CanBlitTextureToTexture) { | |||
| // Blit `bridge` to the top left corner of the texture. | |||
| pass->AddCopy(bridge, texture); | |||
|
|
|||
| pass->EncodeCommands(context->GetResourceAllocator()); | |||
| assert(pass->EncodeCommands(context->GetResourceAllocator())); | |||
There was a problem hiding this comment.
asserts get stripped away in !defined(NDEBUG). Besides, let's not terminate the process on this error. Return false like elsewhere?
|
Really supportive of this change except for the stripped away thing that you want to do :) |
bdero
force-pushed
the
bdero/use-blit-pass
branch
from
b826efc
to
437eea6
Compare
chinmaygarde
approved these changes
Feb 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a blit for the root pass copy when available in the backend.