Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Roll Dart SDK from b1016d8f293a to c757f4bf468d (2 revisions)" #40054

Conversation

zanderso
Copy link
Member

@zanderso zanderso commented Mar 3, 2023

Reverts #40052

g3 is on version 3.0.0-290.0.dev

Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso zanderso merged commit 18f7152 into main Mar 3, 2023
@zanderso zanderso deleted the revert-40052-dart-sdk-flutter-engine-3fe116b1-1f00-4a97-854c-bc3e7c359de8-1677851289 branch March 3, 2023 17:33
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2023
@a-siva
Copy link
Contributor

a-siva commented Mar 3, 2023

What was the failure that resulted in this revert ?

@zanderso
Copy link
Member Author

zanderso commented Mar 3, 2023

The revert was for branch alignment. We should be able to restart rolls towards the end of the day today.

@a-siva
Copy link
Contributor

a-siva commented Mar 3, 2023

Cool, does this mean you have a hash already in place ?

@zanderso
Copy link
Member Author

zanderso commented Mar 3, 2023

The Dart version is likely to be 3.0.0-290.0.dev, but we don't have flutter/engine or flutter/flutter hashes yet no. The previous internal roll is still wrapping up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants