[Impeller] use native decal on metal and Vulkan backend #40723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
changed the title
jonahwilliams
commented
Mar 28, 2023
jonahwilliams
changed the title
jonahwilliams
commented
Mar 29, 2023
| .setAddressModeU(address_mode_u) | ||
| .setAddressModeV(address_mode_v) | ||
| .setAddressModeW(address_mode_w) | ||
| .setBorderColor(vk::BorderColor::eFloatTransparentBlack) |
There was a problem hiding this comment.
I suspect that setting the border color if clamp to border isn't set should have no impact but I have not verified this yet.
There was a problem hiding this comment.
I can't run vulkan right now :(
There was a problem hiding this comment.
Verified that this works on Vulkan without extensions.
chinmaygarde
approved these changes
Mar 30, 2023
| .setAddressModeU(address_mode_u) | ||
| .setAddressModeV(address_mode_v) | ||
| .setAddressModeW(address_mode_w) | ||
| .setBorderColor(vk::BorderColor::eFloatTransparentBlack) |
There was a problem hiding this comment.
Verified that this works on Vulkan without extensions.
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#123619
Implements the decal tile mode with a clamp to border w/ transparent black border color. Should perform better by removing extra ops in the fragment shaders. This could be measurable in the blur case.