[Impeller] Guard against empty grid sizes #40769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Mar 29, 2023
| @@ -55,6 +55,8 @@ | |||
| return false; | |||
| } | |||
|
|
|||
| FML_DCHECK(!grid_size_.IsEmpty() && !thread_group_size_.IsEmpty()); | |||
There was a problem hiding this comment.
We use VALIDATION_LOG for such things and return false from here maybe.
There was a problem hiding this comment.
That's too strong. VALIDATION_LOG will kill the process. An application could get here by mistake and should fizzle instead of dying.
There was a problem hiding this comment.
(but a test should die)
| @@ -47,6 +47,11 @@ bool ComputePass::AddCommand(ComputeCommand command) { | |||
| } | |||
|
|
|||
| bool ComputePass::EncodeCommands() const { | |||
| if (grid_size_.IsEmpty() || thread_group_size_.IsEmpty()) { | |||
There was a problem hiding this comment.
Ditto about the validation logs.
There was a problem hiding this comment.
Same comment - I think making this a fatal error is too strong.
dnfield
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 30, 2023
sourcegraph-bot
pushed a commit
to sgtest/megarepo
that referenced
this pull request
Mar 30, 2023
…/engine#40769) (#123801) Commit: 4a7fca08d9396ba00b436d1224192afd62adab85
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2023
8 tasks
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
…0769) (flutter#123801) Roll Flutter Engine from 7d190aa0e19f to 35507f9e91a7 (1 revision)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Metal, this will trigger a runtime assert if not guarded against further down. We should avoid doing the dispatch at all if the grid size is zero in any dimension.