Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Impeller] Fallback to graphics queue is transfer queue is not available #40787

Merged
merged 1 commit into from Mar 30, 2023

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Mar 30, 2023

On some devices (for example an Android Pixel 4), a dedicated transfer queue is not available. This should not be considered a fatal error - instead we should use the graphics queue for transfer.

Fixes flutter/flutter#123791

…ble.

On some devices (for example an Android Pixel 4), a dedicated transfer queue is not available. This should not be considered a fatal error - instead we should use the graphics queue for transfer.

Fixes flutter/flutter#123791
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use the transfer queue at all right now. Just FYI. I think we'll end up needing one eventually though.

@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 30, 2023
@dnfield
Copy link
Contributor Author

dnfield commented Mar 30, 2023

We don't use the transfer queue at all right now. Just FYI. I think we'll end up needing one eventually though.

I noticed that but wasn't sure if I was just missing something.

@auto-submit auto-submit bot merged commit f0d3ec3 into main Mar 30, 2023
37 checks passed
@auto-submit auto-submit bot deleted the dnfield-patch-3 branch March 30, 2023 17:36
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller needs tests
Projects
No open projects
Archived in project
2 participants