-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fuchsia] Implement thread priorities. #40970
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
674de52
to
bdcd67c
Compare
This PR primarily changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eieio Can you suggest a reviewer? If not, I can RSLGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 based on general approach which we have used in many places for Fuchsia. Needs Flutter-specific review and approval.
LGTM very welcome. This is a pretty urgent change for a release blocking bug. Thanks! |
bdcd67c
to
5f662c2
Compare
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
@flutter-dashboard: I don't believe you. This change only affects thread priorities and in any tests here they should be a no-op entirely. |
5f662c2
to
60dfaf7
Compare
Updated based on offline conversation about the platform thread being important to input latency. This final change should be good to go! |
Golden file changes are available for triage from new commit, Click here to view. |
Implement thread priorities using the Fuchsia media profile provider API to enable system / product configuration of host threads. Bug: b/275114261
60dfaf7
to
189508c
Compare
Thanks, everyone! |
Implement thread priorities using the Fuchsia media profile provider API to enable system / product configuration of host threads. Bug: b/275114261 This is a CP of #40970 with a couple of changes to .cmx files that no longer exist on master.
[Fuchsia] Implement thread priorities.
Implement thread priorities using the Fuchsia media profile provider API to enable system / product configuration of host threads.
This change helps to address b/275114261.