Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SemanticsAction / SemanticsFlag cleanup part 5 #41126

Merged
merged 1 commit into from Apr 12, 2023

Conversation

bernaferrari
Copy link
Contributor

@bernaferrari bernaferrari commented Apr 12, 2023

Final part of flutter/flutter#123346 (before deprecating describeEnum)
Remove temporary variables.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Apr 12, 2023
@bernaferrari
Copy link
Contributor Author

cc @goderbauer @chunhtai

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bernaferrari
Copy link
Contributor Author

Should it trigger google testing on the engine? Nothing happened. Not even the "missing test" bot got triggered.

Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 12, 2023
@auto-submit auto-submit bot merged commit 4485dd4 into flutter:main Apr 12, 2023
35 checks passed
@bernaferrari bernaferrari deleted the semantics-part5 branch April 12, 2023 20:14
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 12, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 12, 2023
zhongwuzw pushed a commit to zhongwuzw/engine that referenced this pull request Apr 14, 2023
`SemanticsAction` / `SemanticsFlag` cleanup part 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine
Projects
None yet
3 participants