Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☂️ Cleanup SemanticsFlag and SemanticsAction. #123346

Closed
6 tasks done
bernaferrari opened this issue Mar 23, 2023 · 2 comments
Closed
6 tasks done

☂️ Cleanup SemanticsFlag and SemanticsAction. #123346

bernaferrari opened this issue Mar 23, 2023 · 2 comments
Assignees
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: proposal A detailed proposal for a change to Flutter engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. P1 High-priority issues at the top of the work list r: fixed Issue is closed as already fixed in a newer version team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@bernaferrari
Copy link
Contributor

bernaferrari commented Mar 23, 2023

These two classes should be an enum, because they work as enum, but they are older than the enhanced enum, so this wasn't possible before. Now it is.

We can remove 200 LOC of these classes and make them as similar as they can be to enums. Enum has its own index, so it clashes with the index from them and would be a super breaking change because affects Google Testing. But changing everything else and cleanup isn't.

This is kind of breaking because Flutter uses semanticsFlag.values.values, but I searched on code search and couldn't find a repo that uses that (besides code-gen), so it seems really internal.

@danagbemava-nc danagbemava-nc added in triage Presently being triaged by the triage team framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine repository. See also e: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: proposal A detailed proposal for a change to Flutter and removed in triage Presently being triaged by the triage team labels Mar 24, 2023
@chinmaygarde chinmaygarde added the P1 High-priority issues at the top of the work list label Mar 27, 2023
@bernaferrari bernaferrari changed the title ☂️ Migrate SemanticsFlag and SemanticsAction to enum. ☂️ Cleanup SemanticsFlag and SemanticsAction. Apr 11, 2023
@flutter-triage-bot flutter-triage-bot bot added multiteam-retriage-candidate team-engine Owned by Engine team triaged-engine Triaged by Engine team labels Jul 8, 2023
auto-submit bot pushed a commit that referenced this issue Aug 9, 2023
@bernaferrari
Copy link
Contributor Author

Everything is complete now.

@danagbemava-nc danagbemava-nc added the r: fixed Issue is closed as already fixed in a newer version label Aug 10, 2023
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: proposal A detailed proposal for a change to Flutter engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. P1 High-priority issues at the top of the work list r: fixed Issue is closed as already fixed in a newer version team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
None yet
Development

No branches or pull requests

3 participants