☂️ Cleanup SemanticsFlag
and SemanticsAction
.
#123346
Labels
a: accessibility
Accessibility, e.g. VoiceOver or TalkBack. (aka a11y)
c: proposal
A detailed proposal for a change to Flutter
engine
flutter/engine repository. See also e: labels.
framework
flutter/packages/flutter repository. See also f: labels.
P1
High-priority issues at the top of the work list
r: fixed
Issue is closed as already fixed in a newer version
team-engine
Owned by Engine team
triaged-engine
Triaged by Engine team
These two classes should be an enum, because they work as enum, but they are older than the enhanced enum, so this wasn't possible before. Now it is.We can remove 200 LOC of these classes and make them as similar as they can be to enums. Enum has its own index, so it clashes with the index from them and would be a super breaking change because affects Google Testing. But changing everything else and cleanup isn't.
This is kind of breaking because Flutter uses semanticsFlag.values.values, but I searched on code search and couldn't find a repo that uses that (besides code-gen), so it seems really internal.
valuesAsList
(SemanticsFlag
/SemanticsAction
cleanup (part 1) engine#40571)valuesAsList
(SemanticsFlag
/SemanticsAction
cleanup (part 2) #123817)convert to enumcleanup (SemanticsFlag
/SemanticsAction
cleanup (part 3) engine#40567)values
again (SemanticsFlag
/SemanticsAction
cleanup (part 4) #123329)valuesAsList
(SemanticsAction
/SemanticsFlag
cleanup part 5 engine#41126)describeEnum
(DeprecatedescribeEnum
. #125016)The text was updated successfully, but these errors were encountered: