[Impeller] Provide an opaque interface for color sources in Aiks #41315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdero
force-pushed
the
bdero/color-sources
branch
2 times, most recently
from
15669fe
to
e247f10
Compare
bdero
force-pushed
the
bdero/color-sources
branch
from
e247f10
to
05e0e1b
Compare
zanderso
reviewed
Apr 18, 2023
| kConicalGradient, | ||
| kSweepGradient, | ||
| kRuntimeEffect, | ||
| kScene, |
There was a problem hiding this comment.
Not quite following where the Scene stuff needs to be #ifdef'd out vs. in. Why is this in the clear here, but Scene code under IMPELLER_ENABLE_3D in others?
There was a problem hiding this comment.
Currently we always build Scene as part of Impeller, but completely eliminate it from the DisplayList + UI unless IMPELLER_ENABLE_3D is on to make accidental exposure impossible. Maybe we should rename it to e.g. FLUTTER_ENABLE_3D sometime. 😄
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 19, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 19, 2023
…125094) flutter/engine@099ed6c...8b7cdb0 2023-04-19 aam@google.com Roll dart, zlib, emscripten, tweak license script for rolled zlib (flutter/engine#41299) 2023-04-19 skia-flutter-autoroll@skia.org Roll Skia from 84630c3c18b2 to 5a718d9e9c06 (3 revisions) (flutter/engine#41318) 2023-04-19 bdero@google.com [Impeller] Provide an opaque interface for color sources in Aiks (flutter/engine#41315) 2023-04-18 yjbanov@google.com [web:canvaskit] remove unnecessary instrumentation from picture (flutter/engine#41313) 2023-04-18 skia-flutter-autoroll@skia.org Roll Skia from 476ee3fd54cc to 84630c3c18b2 (5 revisions) (flutter/engine#41316) 2023-04-18 godofredoc@google.com Double zip FlutterMacOS.framework.zip. (flutter/engine#41306) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#125017.
Pulls ColorSource construction out of the dispatcher and into Aiks.
Cleans up a few design warts we've accumulated over time:
Paint.SolidColorContentsaColorSourceContents.FYI @iamralpht