New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[Impeller] Turned on wide gamut support by default." #41382
Conversation
This reverts commit 879308a.
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
auto label is removed for flutter/engine, pr: 41382, due to - The status or check suite Linux linux_android_aot_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto label is removed for flutter/engine, pr: 41382, due to - The status or check suite Windows Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
…125290) flutter/engine@122c3b3...a7899c4 2023-04-21 skia-flutter-autoroll@skia.org Roll Skia from 524ecb58945e to 90a93bb0990f (1 revision) (flutter/engine#41390) 2023-04-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 4OrPF9lzqCKGwBLRh... to fMOcI5zn1z0nOrV7s... (flutter/engine#41389) 2023-04-21 skia-flutter-autoroll@skia.org Roll Skia from f4609aa2eaba to 524ecb58945e (23 revisions) (flutter/engine#41388) 2023-04-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 50b96abe9f6f to 4cc2e637a315 (1 revision) (flutter/engine#41387) 2023-04-21 54558023+keyonghan@users.noreply.github.com Update xcode to 14c18 (flutter/engine#41370) 2023-04-21 zanderso@users.noreply.github.com Revert "[Impeller] Turned on wide gamut support by default." (flutter/engine#41382) 2023-04-21 chillers@google.com Revert "Manual roll skia to d5b4acfb4" (flutter/engine#41381) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from 4OrPF9lzqCKG to fMOcI5zn1z0n If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/flutter#125276 seems to have been because of the wide gamut rendering too. |
Reverts #39801
customer: chalk
hit some rendering issues that was narrowed down to this: b/278976014