Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of "outrageous" default text styles for HTML renderer. #41822

Merged
merged 6 commits into from
May 8, 2023
Merged

Get rid of "outrageous" default text styles for HTML renderer. #41822

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a60e635
Get rid of "outrageous" default text styles for HTML renderer.
eyebrowsoffire May 8, 2023
51b561c
Also remove default color from the root text style node.
eyebrowsoffire May 8, 2023
4fc3f20
Fix null assertion.
eyebrowsoffire May 8, 2023
69ae0f6
Remove obsolete test.
eyebrowsoffire May 8, 2023
d54ef8e
Change style expectations.
eyebrowsoffire May 8, 2023
d9d8d40
Fix layout fragmenter test expectations.
eyebrowsoffire May 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 0 additions & 4 deletions lib/web_ui/lib/src/engine/global_styles.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,9 @@ void applyGlobalCssRulesToSheet(
assert(styleElement.sheet != null);
final DomCSSStyleSheet sheet = styleElement.sheet! as DomCSSStyleSheet;

// These are intentionally outrageous font parameters to make sure that the
// apps fully specify their text styles.
//
// Fixes #115216 by ensuring that our parameters only affect the flt-scene-host children.
sheet.insertRule('''
$cssSelectorPrefix flt-scene-host {
color: red;
font: $defaultCssFont;
}
''', sheet.cssRules.length);
Expand Down