New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of "outrageous" default text styles for HTML renderer. #41822
Get rid of "outrageous" default text styles for HTML renderer. #41822
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for removing this!
You probably want to remove this one too:
final ui.Color _color = _defaultTextColor; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auto label is removed for flutter/engine, pr: 41822, due to - The status or check suite Linux Web Framework tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
…126309) flutter/engine@8d3a816...824cd09 2023-05-09 godofredoc@google.com Increase timeout of orchestrator. (flutter/engine#41839) 2023-05-09 ianloic@google.com [fuchsia] Stop calling FIDL from Dart in Flutter integration tests (flutter/engine#41669) 2023-05-09 wez@google.com [tests] Remove unused fuchsia.sys protocol reference (flutter/engine#41826) 2023-05-09 skia-flutter-autoroll@skia.org Roll Skia from 7736fbaf84f0 to 485cd3d0f9ca (6 revisions) (flutter/engine#41840) 2023-05-09 30870216+gaaclarke@users.noreply.github.com [Impeller] introduces DeviceHolder to avoid accessing a dead Device (flutter/engine#41748) 2023-05-08 jacksongardner@google.com Get rid of "outrageous" default text styles for HTML renderer. (flutter/engine#41822) 2023-05-08 flar@google.com Adjust DL filter bounds tests to not rely on exact Skia results (flutter/engine#41792) 2023-05-08 skia-flutter-autoroll@skia.org Roll Dart SDK from a8b6687327d6 to 498cfa57165b (1 revision) (flutter/engine#41823) 2023-05-08 JonathanPeterCole@gmail.com [Android] Fix incorrect viewInsets during keyboard animation with EdgeToEdge (flutter/engine#39391) 2023-05-08 skia-flutter-autoroll@skia.org Roll Skia from 951eb9653163 to 7736fbaf84f0 (1 revision) (flutter/engine#41821) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
The CanvasKit renderer doesn't do this, so we should just remove the red text global style.