Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Remove unused fuchsia.sys protocol reference #41826

Merged
merged 2 commits into from
May 9, 2023

Conversation

drwez
Copy link
Contributor

@drwez drwez commented May 8, 2023

Remove reference to unused fuchsia.sys.Environment protocol in test Realm setup. Besides being unused,
the reference was not correctly matched by an #include, nor a GN build dependency.

Bug: fxbug.dev/81285

@drwez
Copy link
Contributor Author

drwez commented May 8, 2023

@arbreng PTAL - this should be the final remaining change (indirectly) required to allow the legacy CreateView() to be removed from Fuchsia.

@arbreng arbreng self-requested a review May 9, 2023 01:32
@arbreng arbreng merged commit a84b7aa into flutter:main May 9, 2023
29 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 9, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 9, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 9, 2023
…126309)

flutter/engine@8d3a816...824cd09

2023-05-09 godofredoc@google.com Increase timeout of orchestrator. (flutter/engine#41839)
2023-05-09 ianloic@google.com [fuchsia] Stop calling FIDL from Dart in Flutter integration tests (flutter/engine#41669)
2023-05-09 wez@google.com [tests] Remove unused fuchsia.sys protocol reference (flutter/engine#41826)
2023-05-09 skia-flutter-autoroll@skia.org Roll Skia from 7736fbaf84f0 to 485cd3d0f9ca (6 revisions) (flutter/engine#41840)
2023-05-09 30870216+gaaclarke@users.noreply.github.com [Impeller] introduces DeviceHolder to avoid accessing a dead Device (flutter/engine#41748)
2023-05-08 jacksongardner@google.com Get rid of "outrageous" default text styles for HTML renderer. (flutter/engine#41822)
2023-05-08 flar@google.com Adjust DL filter bounds tests to not rely on exact Skia results (flutter/engine#41792)
2023-05-08 skia-flutter-autoroll@skia.org Roll Dart SDK from a8b6687327d6 to 498cfa57165b (1 revision) (flutter/engine#41823)
2023-05-08 JonathanPeterCole@gmail.com [Android] Fix incorrect viewInsets during keyboard animation with EdgeToEdge (flutter/engine#39391)
2023-05-08 skia-flutter-autoroll@skia.org Roll Skia from 951eb9653163 to 7736fbaf84f0 (1 revision) (flutter/engine#41821)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants