Implement text rendering in Skwasm #41832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
mdebbar
approved these changes
May 9, 2023
Co-authored-by: Mouad Debbar <mouad.debbar@gmail.com>
8 tasks
eyebrowsoffire
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 10, 2023
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
May 10, 2023
…ions) (#126445) Manual roll requested by zra@google.com flutter/engine@78f41a8...10ac36c 2023-05-09 jacksongardner@google.com Implement text rendering in Skwasm (flutter/engine#41832) 2023-05-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from leCRDVJ8szOS2LsPV... to lf8VcONMWlne4oa3H... (flutter/engine#41876) 2023-05-09 30870216+gaaclarke@users.noreply.github.com [Impeller] started cleaning up pools when devices are deleted (flutter/engine#41857) 2023-05-09 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from c4JvQUEOBHgtRdNPc... to JiOACcaGrDphuHIql... (flutter/engine#41874) 2023-05-09 godofredoc@google.com Move linux_license to engine v2. (flutter/engine#41863) 2023-05-09 godofredoc@google.com Replace Windows Unopt with the engine v2 version. (flutter/engine#41861) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from leCRDVJ8szOS to lf8VcONMWlne fuchsia/sdk/core/mac-amd64 from c4JvQUEOBHgt to JiOACcaGrDph If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…ions) (flutter#126445) Manual roll requested by zra@google.com flutter/engine@78f41a8...10ac36c 2023-05-09 jacksongardner@google.com Implement text rendering in Skwasm (flutter/engine#41832) 2023-05-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from leCRDVJ8szOS2LsPV... to lf8VcONMWlne4oa3H... (flutter/engine#41876) 2023-05-09 30870216+gaaclarke@users.noreply.github.com [Impeller] started cleaning up pools when devices are deleted (flutter/engine#41857) 2023-05-09 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from c4JvQUEOBHgtRdNPc... to JiOACcaGrDphuHIql... (flutter/engine#41874) 2023-05-09 godofredoc@google.com Move linux_license to engine v2. (flutter/engine#41863) 2023-05-09 godofredoc@google.com Replace Windows Unopt with the engine v2 version. (flutter/engine#41861) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from leCRDVJ8szOS to lf8VcONMWlne fuchsia/sdk/core/mac-amd64 from c4JvQUEOBHgt to JiOACcaGrDph If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements full text rendering with the Skwasm renderer.
The font fallback logic has been refactored to decouple the font fallback manager from any CanvasKit-specific types and functions.
A chunk of CanvasKit text rendering tests have been ported over to the renderer-agnostic
uitests.Fixes flutter/flutter#126339