Move linux_license to engine v2. #41863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linux license v2 builds has been running successfully for a few days and it is ready to get moved to prod.
zanderso
approved these changes
May 9, 2023
godofredoc
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 10, 2023
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
May 10, 2023
…ions) (#126445) Manual roll requested by zra@google.com flutter/engine@78f41a8...10ac36c 2023-05-09 jacksongardner@google.com Implement text rendering in Skwasm (flutter/engine#41832) 2023-05-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from leCRDVJ8szOS2LsPV... to lf8VcONMWlne4oa3H... (flutter/engine#41876) 2023-05-09 30870216+gaaclarke@users.noreply.github.com [Impeller] started cleaning up pools when devices are deleted (flutter/engine#41857) 2023-05-09 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from c4JvQUEOBHgtRdNPc... to JiOACcaGrDphuHIql... (flutter/engine#41874) 2023-05-09 godofredoc@google.com Move linux_license to engine v2. (flutter/engine#41863) 2023-05-09 godofredoc@google.com Replace Windows Unopt with the engine v2 version. (flutter/engine#41861) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from leCRDVJ8szOS to lf8VcONMWlne fuchsia/sdk/core/mac-amd64 from c4JvQUEOBHgt to JiOACcaGrDph If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
godofredoc
added a commit
that referenced
this pull request
May 10, 2023
This reverts commit 9ee91b8.
CaseyHillers
pushed a commit
that referenced
this pull request
May 15, 2023
CP: 9ee91b8 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I signed the [CLA]. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…ions) (flutter#126445) Manual roll requested by zra@google.com flutter/engine@78f41a8...10ac36c 2023-05-09 jacksongardner@google.com Implement text rendering in Skwasm (flutter/engine#41832) 2023-05-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from leCRDVJ8szOS2LsPV... to lf8VcONMWlne4oa3H... (flutter/engine#41876) 2023-05-09 30870216+gaaclarke@users.noreply.github.com [Impeller] started cleaning up pools when devices are deleted (flutter/engine#41857) 2023-05-09 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from c4JvQUEOBHgtRdNPc... to JiOACcaGrDphuHIql... (flutter/engine#41874) 2023-05-09 godofredoc@google.com Move linux_license to engine v2. (flutter/engine#41863) 2023-05-09 godofredoc@google.com Replace Windows Unopt with the engine v2 version. (flutter/engine#41861) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from leCRDVJ8szOS to lf8VcONMWlne fuchsia/sdk/core/mac-amd64 from c4JvQUEOBHgt to JiOACcaGrDph If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux license v2 builds has been running successfully for a few days and it is ready to get moved to prod.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.