Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Cleaner output on LUCI #41989

Merged
merged 3 commits into from May 12, 2023
Merged

[web] Cleaner output on LUCI #41989

merged 3 commits into from May 12, 2023

Conversation

mdebbar
Copy link
Contributor

@mdebbar mdebbar commented May 12, 2023

Using ansi colors in LUCI results in output that looks like:

00:00 �[32m+0�[0m: �[1m�[90mloading flutter_tester_emulation_golden_test.dart�[0m�[0m                                                                                                                                            
00:01 �[32m+0�[0m: �[1m�[90mloading flutter_tester_emulation_golden_test.dart�[0m�[0m                                                                                                                                            
00:02 �[32m+0�[0m: �[1m�[90mloading flutter_tester_emulation_golden_test.dart�[0m�[0m

This PR disables colors on LUCI so that we get clean output that's easily scannable and searchable.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label May 12, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label May 12, 2023
@auto-submit auto-submit bot merged commit 968cd95 into flutter:main May 12, 2023
26 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 13, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 13, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 13, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 13, 2023
…126725)

flutter/engine@502e1eb...12e436d

2023-05-13 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from rO5qs4MpN6WfJcu64... to oc2gdx4PWYT-K7XQ9... (flutter/engine#42000)
2023-05-12 skia-flutter-autoroll@skia.org Roll Skia from 64bdd87fadfe to 6a4e29cbd73b (2 revisions) (flutter/engine#41999)
2023-05-12 jason-simmons@users.noreply.github.com [Impeller] Remove a debug log from the Vulkan render pass (flutter/engine#41987)
2023-05-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 858f83d6d993 to 2a285d87f5d7 (2 revisions) (flutter/engine#41997)
2023-05-12 bdero@google.com [Impeller] Ignore the Z basis when scaling text (flutter/engine#41995)
2023-05-12 skia-flutter-autoroll@skia.org Roll Skia from 539fb10d7cfb to 64bdd87fadfe (18 revisions) (flutter/engine#41993)
2023-05-12 mdebbar@google.com [web] Cleaner output on LUCI (flutter/engine#41989)
2023-05-12 leroux_bruno@yahoo.fr [Web+Linux] Fix pressing Meta keys throws (flutter/engine#41694)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from rO5qs4MpN6Wf to oc2gdx4PWYT-

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
…lutter#126725)

flutter/engine@502e1eb...12e436d

2023-05-13 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from rO5qs4MpN6WfJcu64... to oc2gdx4PWYT-K7XQ9... (flutter/engine#42000)
2023-05-12 skia-flutter-autoroll@skia.org Roll Skia from 64bdd87fadfe to 6a4e29cbd73b (2 revisions) (flutter/engine#41999)
2023-05-12 jason-simmons@users.noreply.github.com [Impeller] Remove a debug log from the Vulkan render pass (flutter/engine#41987)
2023-05-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 858f83d6d993 to 2a285d87f5d7 (2 revisions) (flutter/engine#41997)
2023-05-12 bdero@google.com [Impeller] Ignore the Z basis when scaling text (flutter/engine#41995)
2023-05-12 skia-flutter-autoroll@skia.org Roll Skia from 539fb10d7cfb to 64bdd87fadfe (18 revisions) (flutter/engine#41993)
2023-05-12 mdebbar@google.com [web] Cleaner output on LUCI (flutter/engine#41989)
2023-05-12 leroux_bruno@yahoo.fr [Web+Linux] Fix pressing Meta keys throws (flutter/engine#41694)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from rO5qs4MpN6Wf to oc2gdx4PWYT-

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@mdebbar mdebbar deleted the ci_clean_logs branch June 22, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests platform-web Code specifically for the web engine
Projects
None yet
3 participants