[Impeller] Ignore the Z basis when scaling text #41995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
May 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 12, 2023
|
@bdero any idea on how long it will take to get down to stable branch? |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 13, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 13, 2023
…126725) flutter/engine@502e1eb...12e436d 2023-05-13 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from rO5qs4MpN6WfJcu64... to oc2gdx4PWYT-K7XQ9... (flutter/engine#42000) 2023-05-12 skia-flutter-autoroll@skia.org Roll Skia from 64bdd87fadfe to 6a4e29cbd73b (2 revisions) (flutter/engine#41999) 2023-05-12 jason-simmons@users.noreply.github.com [Impeller] Remove a debug log from the Vulkan render pass (flutter/engine#41987) 2023-05-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 858f83d6d993 to 2a285d87f5d7 (2 revisions) (flutter/engine#41997) 2023-05-12 bdero@google.com [Impeller] Ignore the Z basis when scaling text (flutter/engine#41995) 2023-05-12 skia-flutter-autoroll@skia.org Roll Skia from 539fb10d7cfb to 64bdd87fadfe (18 revisions) (flutter/engine#41993) 2023-05-12 mdebbar@google.com [web] Cleaner output on LUCI (flutter/engine#41989) 2023-05-12 leroux_bruno@yahoo.fr [Web+Linux] Fix pressing Meta keys throws (flutter/engine#41694) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from rO5qs4MpN6Wf to oc2gdx4PWYT- If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
We can cherry-pick this patch this week. Its small, has a test, and is can be clearly reasoned about. I've added it to the list on the weekly to review feedback from the last release in case it doesn't get CP-ed early in the week. |
bdero
added a commit
to bdero/flutter-engine
that referenced
this pull request
May 15, 2023
Fixes flutter/flutter#126510. `GetMaxBasisLength()` includes the Z basis vector, which happens to not be getting scaled down along with the X and Y for this reproduction case. And so given the 2D nature of text and the intent of this scale parameter, it's returning a value that's too large here. (cherry picked from commit 6dc9b28)
XilaiZhang
pushed a commit
that referenced
this pull request
May 15, 2023
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…lutter#126725) flutter/engine@502e1eb...12e436d 2023-05-13 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from rO5qs4MpN6WfJcu64... to oc2gdx4PWYT-K7XQ9... (flutter/engine#42000) 2023-05-12 skia-flutter-autoroll@skia.org Roll Skia from 64bdd87fadfe to 6a4e29cbd73b (2 revisions) (flutter/engine#41999) 2023-05-12 jason-simmons@users.noreply.github.com [Impeller] Remove a debug log from the Vulkan render pass (flutter/engine#41987) 2023-05-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 858f83d6d993 to 2a285d87f5d7 (2 revisions) (flutter/engine#41997) 2023-05-12 bdero@google.com [Impeller] Ignore the Z basis when scaling text (flutter/engine#41995) 2023-05-12 skia-flutter-autoroll@skia.org Roll Skia from 539fb10d7cfb to 64bdd87fadfe (18 revisions) (flutter/engine#41993) 2023-05-12 mdebbar@google.com [web] Cleaner output on LUCI (flutter/engine#41989) 2023-05-12 leroux_bruno@yahoo.fr [Web+Linux] Fix pressing Meta keys throws (flutter/engine#41694) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from rO5qs4MpN6Wf to oc2gdx4PWYT- If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#126510.
GetMaxBasisLength()includes the Z basis vector, which happens to not be getting scaled down along with the X and Y for this reproduction case. And so given the 2D nature of text and the intent of this scale parameter, it's returning a value that's too large here.We just haven't encountered this situation before because usually all dimensions of the matrix get scaled down, or point size of the text gets decreased instead
Before:
After:
