Reland "[ios_platform_view] only recycle maskView when the view is applying mutators #41573" #42115

cyanglaz · 2023-05-18T00:48:36Z

The original PR (#41573) was reverted due to flutter/flutter#126951

The issue will be fixed in #42079

This needs to be landed after #42079

fixes: flutter/flutter#125620

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…ew is applying mutators" (flutter#42080)" This reverts commit 1c775e3.

chinmaygarde · 2023-05-18T20:07:06Z

Per the description, this is waiting on #42079

cyanglaz · 2023-05-18T22:45:32Z

Per the description, this is waiting on #42079

We decided to combine two PRs for easier cherry-pick. I will merge #42079 into this PR before landing this.

cyanglaz · 2023-05-19T17:23:42Z

Merged #42079

@dkwingsmt @hellohuanlin Could you give it a quick review to ensure the test is good?

hellohuanlin · 2023-05-19T17:32:01Z

i think i reviewed the original PR. is there any changes since then? otherwise we are good to go.

cyanglaz · 2023-05-19T17:33:43Z

i think i reviewed the original PR. is there any changes since then? otherwise we are good to go.

No change, just merged directly.

auto-submit · 2023-05-19T17:36:42Z

auto label is removed for flutter/engine, pr: 42115, due to - The status or check suite Linux mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2023-05-19T19:44:00Z

auto label is removed for flutter/engine, pr: 42115, due to - The status or check suite Windows windows_android_aot_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

dkwingsmt

LGTM for the test change

dkwingsmt

LGTM for the test change

…view is applying mutators flutter#41573" (flutter/engine#42115)

…127364) flutter/engine@a342a91...2a325ee 2023-05-22 skia-flutter-autoroll@skia.org Roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42224) 2023-05-22 jason-simmons@users.noreply.github.com [Impeller] Return image decoder error messages to the Dart API (flutter/engine#42175) 2023-05-22 5236035+fzyzcjy@users.noreply.github.com Again a two-word super tiny typo (flutter/engine#42181) 2023-05-22 ychris@google.com Reland "[ios_platform_view] only recycle maskView when the view is applying mutators #41573" (flutter/engine#42115) 2023-05-22 jason-simmons@users.noreply.github.com [Impeller] Use untransformed text bounds to calculate the size of ColorSourceTextContents (flutter/engine#42142) 2023-05-22 jonahwilliams@google.com [Impeller] Add UV compute shader. (flutter/engine#42192) 2023-05-22 jonahwilliams@google.com [Impeller] remove final cmd buffer waitUntilScheduled on physical iOS (flutter/engine#42160) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…ew is applying mutators #41573" (#42115)" This reverts commit 266524c.

…plying mutators #41573" (#42231) Reverts #42115 Failing on the framework tree as in https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20platform_views_scroll_perf_ios__timeline_summary/11103/overview

Reverts Engine rolls for bad commit in flutter/engine#42115 6549765 194d30a Engine commit is being reverted in flutter/engine#42231

…view is applying mutators flutter#41573" (flutter/engine#42115)

…sions) (#127369) Manual roll requested by zra@google.com flutter/engine@a342a91...2586cbe 2023-05-23 zanderso@users.noreply.github.com Revert "[ios_platform_view] only recycle maskView when the view is applying mutators #41573" (flutter/engine#42231) 2023-05-23 skia-flutter-autoroll@skia.org Roll Skia from ac87929b3d2e to 6a57876d0e44 (2 revisions) (flutter/engine#42230) 2023-05-23 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from QAwORJOkyNl4J3x4Y... to DzmjiSg6XC0JUfbKP... (flutter/engine#42227) 2023-05-23 skia-flutter-autoroll@skia.org Manual roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42229) 2023-05-23 skia-flutter-autoroll@skia.org Roll Skia from d448fe07ea46 to ac87929b3d2e (8 revisions) (flutter/engine#42226) 2023-05-23 dnfield@google.com Make FML_LOG safe from static initialization (flutter/engine#42219) 2023-05-23 uysalere@gmail.com [fuchsia] Bind ChildViewWatcher on platform thread (flutter/engine#42222) 2023-05-22 skia-flutter-autoroll@skia.org Roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42224) 2023-05-22 jason-simmons@users.noreply.github.com [Impeller] Return image decoder error messages to the Dart API (flutter/engine#42175) 2023-05-22 5236035+fzyzcjy@users.noreply.github.com Again a two-word super tiny typo (flutter/engine#42181) 2023-05-22 ychris@google.com Reland "[ios_platform_view] only recycle maskView when the view is applying mutators #41573" (flutter/engine#42115) 2023-05-22 jason-simmons@users.noreply.github.com [Impeller] Use untransformed text bounds to calculate the size of ColorSourceTextContents (flutter/engine#42142) 2023-05-22 jonahwilliams@google.com [Impeller] Add UV compute shader. (flutter/engine#42192) 2023-05-22 jonahwilliams@google.com [Impeller] remove final cmd buffer waitUntilScheduled on physical iOS (flutter/engine#42160) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from QAwORJOkyNl4 to DzmjiSg6XC0J If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#127364) flutter/engine@a342a91...2a325ee 2023-05-22 skia-flutter-autoroll@skia.org Roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42224) 2023-05-22 jason-simmons@users.noreply.github.com [Impeller] Return image decoder error messages to the Dart API (flutter/engine#42175) 2023-05-22 5236035+fzyzcjy@users.noreply.github.com Again a two-word super tiny typo (flutter/engine#42181) 2023-05-22 ychris@google.com Reland "[ios_platform_view] only recycle maskView when the view is applying mutators flutter#41573" (flutter/engine#42115) 2023-05-22 jason-simmons@users.noreply.github.com [Impeller] Use untransformed text bounds to calculate the size of ColorSourceTextContents (flutter/engine#42142) 2023-05-22 jonahwilliams@google.com [Impeller] Add UV compute shader. (flutter/engine#42192) 2023-05-22 jonahwilliams@google.com [Impeller] remove final cmd buffer waitUntilScheduled on physical iOS (flutter/engine#42160) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Reverts Engine rolls for bad commit in flutter/engine#42115 flutter@6549765 flutter@194d30a Engine commit is being reverted in flutter/engine#42231

…sions) (flutter#127369) Manual roll requested by zra@google.com flutter/engine@a342a91...2586cbe 2023-05-23 zanderso@users.noreply.github.com Revert "[ios_platform_view] only recycle maskView when the view is applying mutators flutter#41573" (flutter/engine#42231) 2023-05-23 skia-flutter-autoroll@skia.org Roll Skia from ac87929b3d2e to 6a57876d0e44 (2 revisions) (flutter/engine#42230) 2023-05-23 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from QAwORJOkyNl4J3x4Y... to DzmjiSg6XC0JUfbKP... (flutter/engine#42227) 2023-05-23 skia-flutter-autoroll@skia.org Manual roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42229) 2023-05-23 skia-flutter-autoroll@skia.org Roll Skia from d448fe07ea46 to ac87929b3d2e (8 revisions) (flutter/engine#42226) 2023-05-23 dnfield@google.com Make FML_LOG safe from static initialization (flutter/engine#42219) 2023-05-23 uysalere@gmail.com [fuchsia] Bind ChildViewWatcher on platform thread (flutter/engine#42222) 2023-05-22 skia-flutter-autoroll@skia.org Roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42224) 2023-05-22 jason-simmons@users.noreply.github.com [Impeller] Return image decoder error messages to the Dart API (flutter/engine#42175) 2023-05-22 5236035+fzyzcjy@users.noreply.github.com Again a two-word super tiny typo (flutter/engine#42181) 2023-05-22 ychris@google.com Reland "[ios_platform_view] only recycle maskView when the view is applying mutators flutter#41573" (flutter/engine#42115) 2023-05-22 jason-simmons@users.noreply.github.com [Impeller] Use untransformed text bounds to calculate the size of ColorSourceTextContents (flutter/engine#42142) 2023-05-22 jonahwilliams@google.com [Impeller] Add UV compute shader. (flutter/engine#42192) 2023-05-22 jonahwilliams@google.com [Impeller] remove final cmd buffer waitUntilScheduled on physical iOS (flutter/engine#42160) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from QAwORJOkyNl4 to DzmjiSg6XC0J If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…plying mutators #42115" (#42823) Relands #42115, which was reverted in #42231 due to a crash in the framework test. The crash is due to a memory management issue that I fixed it in this PR, I also added a scenario test to catch the crash. fixes: flutter/flutter#125620 See also: orignal PR #41573 for more details. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

…plying mutators flutter#42115" (flutter#42823) Relands flutter#42115, which was reverted in flutter#42231 due to a crash in the framework test. The crash is due to a memory management issue that I fixed it in this PR, I also added a scenario test to catch the crash. fixes: flutter/flutter#125620 See also: orignal PR flutter#41573 for more details. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

dkwingsmt and others added 3 commits May 16, 2023 13:41

Fix

f85cf9d

Use set

1d3797a

Revert "Revert "[ios_platform_view] only recycle maskView when the vi…

e5ac330

…ew is applying mutators" (flutter#42080)" This reverts commit 1c775e3.

flutter-dashboard bot added the platform-ios label May 18, 2023

cyanglaz requested a review from hellohuanlin May 18, 2023 00:48

cyanglaz marked this pull request as ready for review May 18, 2023 00:48

hellohuanlin approved these changes May 18, 2023

View reviewed changes

cyanglaz mentioned this pull request May 18, 2023

Fix the false failure caused by FlutterClippingMaskViewPool's random algorithm #42079

Closed

8 tasks

NSSet

27c4910

Merge branch '42079' into maskviewpool_reland

cdfc00c

cyanglaz requested a review from dkwingsmt May 19, 2023 17:24

cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label May 19, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 19, 2023

fix build issue

fe1e597

cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label May 19, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 19, 2023

Merge branch 'main' into maskviewpool_reland

e3001fc

stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label May 22, 2023

dkwingsmt approved these changes May 22, 2023

View reviewed changes

auto-submit bot merged commit 266524c into flutter:main May 22, 2023
29 checks passed

engine-flutter-autoroll mentioned this pull request May 22, 2023

Roll Flutter Engine from a342a9186e69 to 10951022cc27 (6 revisions) flutter/flutter#127359

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2023

266524ce3 Reland "[ios_platform_view] only recycle maskView when the …

476499c

…view is applying mutators flutter#41573" (flutter/engine#42115)

engine-flutter-autoroll mentioned this pull request May 23, 2023

Roll Flutter Engine from a342a9186e69 to 2a325eed77d0 (7 revisions) flutter/flutter#127364

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 23, 2023

266524ce3 Reland "[ios_platform_view] only recycle maskView when the …

7432119

…view is applying mutators flutter#41573" (flutter/engine#42115)

zanderso added a commit that referenced this pull request May 23, 2023

Revert "Reland "[ios_platform_view] only recycle maskView when the vi…

58d02e1

…ew is applying mutators #41573" (#42115)" This reverts commit 266524c.

This was referenced May 23, 2023

Revert "[ios_platform_view] only recycle maskView when the view is applying mutators #41573" #42231

Merged

Revert Engine to a342a9186e69 flutter/flutter#127368

Merged

zanderso added a commit to flutter/flutter that referenced this pull request May 23, 2023

Revert Engine to a342a9186e69 (#127368)

bc14fed

Reverts Engine rolls for bad commit in flutter/engine#42115 6549765 194d30a Engine commit is being reverted in flutter/engine#42231

engine-flutter-autoroll mentioned this pull request May 23, 2023

Manual roll Flutter Engine from a342a9186e69 to 2586cbeeae37 (14 revisions) flutter/flutter#127369

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 23, 2023

266524ce3 Reland "[ios_platform_view] only recycle maskView when the …

e75f54d

…view is applying mutators flutter#41573" (flutter/engine#42115)

This was referenced Jun 8, 2023

Clipping 2 or more PlatformViews on iOS only ends up clipping 1 of them flutter/flutter#127717

Closed

PlatformViews are drawn outside of parent widget (beta channel) flutter/flutter#125620

Closed

cyanglaz deleted the maskviewpool_reland branch June 13, 2023 17:06

cyanglaz mentioned this pull request Jun 13, 2023

Reland "[ios_platform_view] only recycle maskView when the view is applying mutators #42115" #42823

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reland "[ios_platform_view] only recycle maskView when the view is applying mutators #41573" #42115

Reland "[ios_platform_view] only recycle maskView when the view is applying mutators #41573" #42115

cyanglaz commented May 18, 2023

chinmaygarde commented May 18, 2023

cyanglaz commented May 18, 2023

cyanglaz commented May 19, 2023 •

edited

hellohuanlin commented May 19, 2023

cyanglaz commented May 19, 2023

auto-submit bot commented May 19, 2023

auto-submit bot commented May 19, 2023

dkwingsmt left a comment

dkwingsmt left a comment

Reland "[ios_platform_view] only recycle maskView when the view is applying mutators #41573" #42115

Reland "[ios_platform_view] only recycle maskView when the view is applying mutators #41573" #42115

Conversation

cyanglaz commented May 18, 2023

Pre-launch Checklist

chinmaygarde commented May 18, 2023

cyanglaz commented May 18, 2023

cyanglaz commented May 19, 2023 • edited

hellohuanlin commented May 19, 2023

cyanglaz commented May 19, 2023

auto-submit bot commented May 19, 2023

auto-submit bot commented May 19, 2023

dkwingsmt left a comment

Choose a reason for hiding this comment

dkwingsmt left a comment

Choose a reason for hiding this comment

cyanglaz commented May 19, 2023 •

edited