Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlutterPlatformViews might trigger false failure with its new pooling algorithm #126951

Closed
dkwingsmt opened this issue May 16, 2023 · 2 comments
Closed

FlutterPlatformViews might trigger false failure with its new pooling algorithm #126951

dkwingsmt opened this issue May 16, 2023 · 2 comments
Assignees
@cyanglaz
Labels
a: platform-views Embedding Android/iOS views in Flutter apps a: tests "flutter test", flutter_test, or one of our tests P1 High-priority issues at the top of the work list platform-ios iOS applications specifically team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team

Comments

@dkwingsmt
Copy link
Contributor

dkwingsmt commented May 16, 2023 •
edited

With flutter/engine#41573, when FlutterClippingMaskViewPool is requested a mask view, it now randomly picks one from its pool. While this behavior is perfectly ok from the outside, it might cause false failure in certain unit tests that assume the result to be deterministic.

Error log: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8780912233583277217/+/u/test:_Tests_for_ios_debug_sim/stdout?format=raw
@dkwingsmt
Copy link
Contributor Author

cc @cyanglaz

@dkwingsmt dkwingsmt mentioned this issue May 16, 2023
Closed
8 tasks
@danagbemava-nc danagbemava-nc added in triage Presently being triaged by the triage team a: tests "flutter test", flutter_test, or one of our tests platform-ios iOS applications specifically a: platform-views Embedding Android/iOS views in Flutter apps and removed in triage Presently being triaged by the triage team labels May 17, 2023
@cyanglaz cyanglaz self-assigned this May 17, 2023
@cyanglaz cyanglaz added the P1 High-priority issues at the top of the work list label May 17, 2023
@cyanglaz cyanglaz mentioned this issue May 18, 2023
Merged
8 tasks
auto-submit bot pushed a commit to flutter/engine that referenced this issue May 22, 2023
Reland "[ios_platform_view] only recycle maskView when the view is ap…
266524c 
…plying mutators #41573" (#42115)

The original PR (#41573) was reverted due to flutter/flutter#126951

The issue will be fixed in #42079

This needs to be landed after #42079

fixes: flutter/flutter#125620

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@flutter-triage-bot flutter-triage-bot bot added team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team labels Jul 8, 2023
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cyanglaz cyanglaz

Labels
a: platform-views Embedding Android/iOS views in Flutter apps a: tests "flutter test", flutter_test, or one of our tests P1 High-priority issues at the top of the work list platform-ios iOS applications specifically team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the false failure caused by FlutterClippingMaskViewPool's random algorithm dkwingsmt/engine
3 participants
@dkwingsmt @cyanglaz @danagbemava-nc