Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Impeller] fix partial repaint texture sizing. #42594

Closed
wants to merge 1 commit into from

Conversation

jonahwilliams
Copy link
Member

Locally this fixes the embedder support regression caused by partial repaint textures being too large.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@zanderso
Copy link
Member

zanderso commented Jun 6, 2023

A bit confused. Wasn't this the fix for the previous regression? 3aebe09.

@jonahwilliams
Copy link
Member Author

that's wrong then ...

We should revert for now until we figure this out I guess

@jonahwilliams
Copy link
Member Author

There may be some confusion as to whether we're wrapping the surface texture or creating a new texture. Whenever we perform a partial repaint, the surface texture isn't used and instead a new texture is created that is a smaller size.

@jonahwilliams
Copy link
Member Author

closing this for now, but the lack of this functionality is the cause of the current regression

@jonahwilliams jonahwilliams deleted the fix_stuff branch June 6, 2023 17:00
@bdero
Copy link
Member

bdero commented Jun 6, 2023

My attempted fix was indeed wrong, but there's another bug in here where I'm re-wrapping the texture with an incorrect descriptor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants