-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Impeller] allowing enabling Impeller on macOS. #42639
Changes from all commits
9a2ab40
caa1f4a
a9e3fa9
73a2e22
6bcb25c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -62,6 +62,9 @@ class EmbedderSurfaceMetalImpeller final : public EmbedderSurface, | |
// |GPUSurfaceMetalDelegate| | ||
bool PresentTexture(GPUMTLTextureInfo texture) const override; | ||
|
||
// |EmbedderSurface| | ||
std::shared_ptr<impeller::Context> CreateImpellerContext() const override; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Need to override this so we get a context for image decoding. |
||
|
||
FML_DISALLOW_COPY_AND_ASSIGN(EmbedderSurfaceMetalImpeller); | ||
}; | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -49,6 +49,7 @@ | |
std::make_shared<fml::SyncSwitch>(false), // is_gpu_disabled_sync_switch | ||
"Impeller Library" // library_label | ||
); | ||
FML_LOG(ERROR) << "Using the Impeller rendering backend (Metal)."; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added an error log here to match the other backends |
||
|
||
valid_ = !!context_; | ||
} | ||
|
@@ -75,6 +76,10 @@ | |
return surface; | ||
} | ||
|
||
std::shared_ptr<impeller::Context> EmbedderSurfaceMetalImpeller::CreateImpellerContext() const { | ||
return context_; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (this is fine because it's set up in the ctor) |
||
} | ||
|
||
GPUCAMetalLayerHandle EmbedderSurfaceMetalImpeller::GetCAMetalLayer( | ||
const SkISize& frame_info) const { | ||
FML_CHECK(false) << "Only rendering to MTLTexture is supported."; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to only using switches