[Impeller] Reland: Added a switch to turn on vulkan #42669
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
This is still adding the Impeller Vulkan backend to release binaries because impeller_enable_vulkan is on by default for Android.
(see https://github.com/flutter/engine/blob/main/impeller/tools/impeller.gni#L21)
shell/platform/android/BUILD.gn
Outdated
| @@ -139,6 +140,10 @@ source_set("flutter_shell_native_src") { | |||
|
|
|||
| defines = [] | |||
|
|
|||
| if (impeller_enable_vulkan) { | |||
| defines += [ "IMPELLER_ENABLE_VULKAN" ] | |||
There was a problem hiding this comment.
This is not needed. IMPELLER_ENABLE_VULKAN will be defined in this module through the dependency on Impeller's public config.
Ahh shoot. I didn't think to look there, I only looked at the builders and gn script. Having that flag on seems in error since we are saying we don't want it. I'm guessing it was just a hack to get CI compilation coverage. |
gaaclarke
force-pushed
the
reland-vulkan-switch
branch
4 times, most recently
from
e4e211a
to
69acad9
Compare
gaaclarke
force-pushed
the
reland-vulkan-switch
branch
from
69acad9
to
09ffb0b
Compare
|
@jason-simmons @zanderso Now that flutter/flutter#128484 is resolved. This is just a straight reland of the original PR. I've removed the attempt to hook into the |
fixes flutter/flutter#128286 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
gaaclarke
force-pushed
the
reland-vulkan-switch
branch
from
09ffb0b
to
6a52437
Compare
gaaclarke
added
the
autosubmit
…128617) flutter/engine@488876e...3e90345 2023-06-09 skia-flutter-autoroll@skia.org Roll ANGLE from 3e4f4caebcb0 to 72df42832ee4 (2 revisions) (flutter/engine#42703) 2023-06-09 skia-flutter-autoroll@skia.org Manual roll Dart SDK from bbce07ad3944 to d5b39a8385f9 (2 revisions) (flutter/engine#42702) 2023-06-09 30870216+gaaclarke@users.noreply.github.com [Impeller] Reland: Added a switch to turn on vulkan (flutter/engine#42669) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
relands #42585
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.