Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the use of contexts on engine_v2 tests. #43013

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Document the use of contexts on engine_v2 tests. #43013

merged 2 commits into from
Jun 21, 2023

Conversation

godofredoc
Copy link
Contributor

Contexts are predefined python contexts that can be dynamically added to the test execution.

Bug: flutter/flutter#129187

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Contexts are predefined python contexts that can be dinamically added to
the test execution.

Bug: flutter/flutter#129187
@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 21, 2023
@auto-submit auto-submit bot merged commit 08c6507 into flutter:main Jun 21, 2023
29 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 21, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 21, 2023
…129306)

flutter/engine@090fae8...08aaa88

2023-06-21 mark@lazycat.hu Enabling pre-push checks on Windows (flutter/engine#36123)
2023-06-21 godofredoc@google.com Document the use of contexts on engine_v2 tests. (flutter/engine#43013)
2023-06-21 godofredoc@google.com Generate treemap. (flutter/engine#43029)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@godofredoc godofredoc deleted the add_docs_contexts branch January 12, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
2 participants