Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate treemap. #43029

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Generate treemap. #43029

merged 3 commits into from
Jun 21, 2023

Conversation

godofredoc
Copy link
Contributor

Engine V2 was not generating the size treemap. This change will start uploading the size treemap to the test logs.

Bug: flutter/flutter#128482

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Engine V2 was not generating the size treemap. This change will start
uploading the size treemap to the test logs.

Bug: flutter/flutter#128482
@godofredoc godofredoc requested a review from zanderso June 21, 2023 05:19
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zanderso
Copy link
Member

Following the link in the android_release_arm64

Screenshot 2023-06-21 at 7 14 00 AM

Gives:

https://storage.googleapis.com/flutter_logs/flutter/5dd47845-4b88-4ff7-a694-7f461816b8c8/Generate%20treemap%20for%20android_release_arm64/5dd47845-4b88-4ff7-a694-7f461816b8c8/index.html

Note that this is a non-LTO build since it is running in presubmit.

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 21, 2023
@auto-submit auto-submit bot merged commit f09280c into flutter:main Jun 21, 2023
29 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 21, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 21, 2023
…129306)

flutter/engine@090fae8...08aaa88

2023-06-21 mark@lazycat.hu Enabling pre-push checks on Windows (flutter/engine#36123)
2023-06-21 godofredoc@google.com Document the use of contexts on engine_v2 tests. (flutter/engine#43013)
2023-06-21 godofredoc@google.com Generate treemap. (flutter/engine#43029)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@godofredoc godofredoc deleted the add_treemap branch January 12, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
2 participants