Set window.viewInsets.bottom to keyboard height on iOS #4420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for us to start migrating framework classes (notably Scaffold) to use window.viewInsets.bottom to get the keyboard height. Once framework updates have landed, we will land an engine patch to expose the iOS bottom safe area inset as padding. This change is already landed for Android.
|
Is there a linkable issue reference? |
|
This is a followup to flutter/flutter#12098, which I'm about to use for flutter/flutter#12099 |
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
Dec 7, 2017
cbracken
added a commit
to flutter/flutter
that referenced
this pull request
Dec 7, 2017
bsalomon
pushed a commit
to bsalomon/engine
that referenced
this pull request
Dec 8, 2017
This allows for us to start migrating framework classes (notably Scaffold) to use window.viewInsets.bottom to get the keyboard height. Once framework updates have landed, we will land an engine patch to expose the iOS bottom safe area inset as padding. This change is already landed for Android. Related issue: flutter/flutter#12098
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for us to start migrating framework classes (notably
Scaffold) to use window.viewInsets.bottom to get the keyboard height.
Once framework updates have landed, we will land an engine patch to
expose the iOS bottom safe area inset as padding.
This change is already landed for Android.
Related issue: flutter/flutter#12098