This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Make Locale know about the deprecated Hebrew language code. #4411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @HansMuller |
HansMuller
reviewed
Dec 5, 2017
| /// Registry](https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry). | ||
| /// Typically this means the primary language subtag should be lowercase and | ||
| /// the region subtag should be uppercase. | ||
| const Locale(this._languageCode, [ this._countryCode ]) : assert(_languageCode != null); |
There was a problem hiding this comment.
NICE. No more `const Locale('foo', '')
HansMuller
reviewed
Dec 5, 2017
| @@ -0,0 +1,58 @@ | |||
| import 'dart:async'; | |||
There was a problem hiding this comment.
A comment that explains what this app is for (even though we may not run it very often) would be good.
|
LGTM |
...by making it know about ALL the deprecated language and region codes.
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
Dec 7, 2017
cbracken
added a commit
to flutter/flutter
that referenced
this pull request
Dec 7, 2017
bsalomon
pushed a commit
to bsalomon/engine
that referenced
this pull request
Dec 8, 2017
…4411) ...by making it know about ALL the deprecated language and region codes.
Hixie
added a commit
to Hixie/flutter
that referenced
this pull request
Dec 11, 2017
Hixie
added a commit
to flutter/flutter
that referenced
this pull request
Dec 11, 2017
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...by making it know about ALL the deprecated language and region codes.