-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a DlStopwatchVisualizer
and conditionally use it for Impeller
#45259
Add a DlStopwatchVisualizer
and conditionally use it for Impeller
#45259
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its not as much of a help if you do a DlVertices per rectangle. instead you should pack all of your rectangles into a single vertices.
I think you might have seen an earlier commit (I did that just to make sure I was triangle-ing correctly, before refactoring into a single buffer). PTAL again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…133720) flutter/engine@8f1b77b...73e8636 2023-08-30 matanlurey@users.noreply.github.com Add a `DlStopwatchVisualizer` and conditionally use it for Impeller (flutter/engine#45259) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closes flutter/flutter#126009.
One major change, as-per @jonahwilliams's feedback, is that I created a helper class called
DlVertexPainter
, which provides aDrawRect
-like API, but just builds a buffer of vertices, resulting into just a single:Also, added test for it, since there is no way to screenshot test to Impeller overlay yet.
Impeller