Revert "Remove some of our hacks around JSPromise now that we have better APIs." #45660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyebrowsoffire
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 11, 2023
…we have better APIs." (flutter/engine#45660)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 11, 2023
…134462) flutter/engine@0774ddc...06696e7 2023-09-11 jacksongardner@google.com Revert "Remove some of our hacks around JSPromise now that we have better APIs." (flutter/engine#45660) 2023-09-11 skia-flutter-autoroll@skia.org Roll Skia from 3ed290acb65f to e6225224fb4e (2 revisions) (flutter/engine#45658) 2023-09-11 kjlubick@users.noreply.github.com Update skwasm build to use safer flush call (flutter/engine#45652) 2023-09-11 jacksongardner@google.com Remove some of our hacks around JSPromise now that we have better APIs. (flutter/engine#45591) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #45591
This is somehow causing some issues with the hot reload tests and blocking engine -> framework rolls. See flutter/flutter#134455