[Impeller] Remove capability to read from onscreen. #47808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
force-pushed
the
remove_read_onscreen
branch
from
311f0b4
to
53c5b50
Compare
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 8, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 8, 2023
…138108) flutter/engine@6dbcf8f...5306213 2023-11-08 34871572+gmackall@users.noreply.github.com Switch to Android 14 for physical device firebase tests (flutter/engine#47016) 2023-11-08 jonahwilliams@google.com [Impeller] remove capability to read from onscreen. (flutter/engine#47808) 2023-11-08 skia-flutter-autoroll@skia.org Roll Skia from a4cce5236dcf to fb69e696dc45 (1 revision) (flutter/engine#47810) 2023-11-08 skia-flutter-autoroll@skia.org Roll Dart SDK from 15c286ed91ea to 14933042494d (5 revisions) (flutter/engine#47805) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
These 2 lines are telling the layer tree that the surface can read from the backdrop. The layer tree will automatically do offscreen rendering as needed if these 2 flags are simply set correctly. |
|
Those flags are ignored by Impeller |
Those flags are info supplied TO the layer tree. Impeller isn't supposed to look at them, it is telling the layer_tree what it can do - and it is lying here. If it had set these flags to false the layer tree would have enforced off-screen rendering already. This whole PR could be replaced by setting those 2 flags to false... |
This was referenced Nov 17, 2023
chinmaygarde
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered by @knopp in flutter/flutter#131567 (comment), this is actually reducing performance substantially when there are multiple blurs. In the case of flutter/flutter#132735 , removing this capbility improves GPU performance from 400ms per frame to ~100 ms per frame.
Fixes flutter/flutter#131567 (comment)