Make lib/ui/{text|window}/... compatible with .clang_tidy.
#48000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just ... deleted `text_box.h` as it appears unused and unreferenced?
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zanderso
approved these changes
Nov 15, 2023
| @@ -1,28 +0,0 @@ | |||
| // Copyright 2013 The Flutter Authors. All rights reserved. | |||
There was a problem hiding this comment.
Out of curiosity, how did you determine that this was dead code?
There was a problem hiding this comment.
It came up in the clang_tidy audit, and I grepped for text_box.h and didn't find any usages outside of metadata.
It looks like it was a Fuchsia-era thing looking at blame history?
|
test-exempt: helps unblock turning on a check that will automatically enforce the change |
jonahwilliams
added
the
revert
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Nov 15, 2023
…`." (#48083) Reverts #48000 Initiated by: jonahwilliams This change reverts the following previous change: Original Description: I just ... deleted `text_box.h` as it appears unused and unreferenced? --- Work towards flutter/flutter#134969. All changes were made automatically (i.e. with `--fix`).
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 16, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 16, 2023
…138529) flutter/engine@3cfcdeb...8aff9c1 2023-11-16 skia-flutter-autoroll@skia.org Roll Dart SDK from cc6acfd7d57c to 5cccc24d127f (1 revision) (flutter/engine#48109) 2023-11-16 skia-flutter-autoroll@skia.org Roll Skia from 5d6bdbf69dea to add865f891c8 (1 revision) (flutter/engine#48108) 2023-11-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 65819963fb17 to cc6acfd7d57c (5 revisions) (flutter/engine#48100) 2023-11-16 matanlurey@users.noreply.github.com Make `fml/status_or.h` compatible with `.clang_tidy`. (flutter/engine#48002) 2023-11-16 dnfield@google.com [Impeller] Gate Vulkan selection on API 29 (flutter/engine#48089) 2023-11-16 chris@bracken.jp [macOS] Clean up allocations in menu plugin test (flutter/engine#48093) 2023-11-16 matanlurey@users.noreply.github.com Re-land "Make `fml/...` compatible with `.clang_tidy` (flutter/engine#48030) 2023-11-15 ychris@google.com [ios] introduce weak_nsobject (flutter/engine#47947) 2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from e954d1a1972c to 5d6bdbf69dea (2 revisions) (flutter/engine#48094) 2023-11-15 jonahwilliams@google.com [Impeller] add async command submission for blit pass. (flutter/engine#48040) 2023-11-15 matanlurey@users.noreply.github.com Make `lib/ui/compositing/...` compatible with `.clang_tidy`. (flutter/engine#48001) 2023-11-15 godofredoc@google.com Remove the linux fuchsia v1 build. (flutter/engine#48085) 2023-11-15 mdebbar@google.com [web] Apply global styles before inserting the DOM element (flutter/engine#48027) 2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from b23074a79bda to e954d1a1972c (7 revisions) (flutter/engine#48092) 2023-11-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `lib/ui/{text|window}/...` compatible with `.clang_tidy`." (flutter/engine#48083) 2023-11-15 41930132+hellohuanlin@users.noreply.github.com [ios]fix ios 16 auto correction highlight showing on top left corner (flutter/engine#47279) 2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from c42226314a4f to b23074a79bda (3 revisions) (flutter/engine#48081) 2023-11-15 matanlurey@users.noreply.github.com Make `lib/ui/{text|window}/...` compatible with `.clang_tidy`. (flutter/engine#48000) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just ... deleted
text_box.has it appears unused and unreferenced?Work towards flutter/flutter#134969.
All changes were made automatically (i.e. with
--fix).