-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Replace use of Fontmgr::RefDefault with explicit creation calls" #48755
Conversation
…ls (flutter#48571)" This reverts commit ab89510. The flutter/tests/skp_generator test (running in flutter_tester on Linux) was failing, along with some customer tests.
cc @kjlubick |
Some tests running in @kjlubick After this revert lands I will send out a PR that relands #48571 and brings back the directory font manager. |
FYI: I'ts not the edit: I see you did that in #48764, great! |
…139716) flutter/engine@347f506...82de334 2023-12-07 jason-simmons@users.noreply.github.com Revert "Replace use of Fontmgr::RefDefault with explicit creation calls" (flutter/engine#48755) 2023-12-07 skia-flutter-autoroll@skia.org Roll Skia from 2abb01e18ab3 to 8ebf43ba1c09 (1 revision) (flutter/engine#48761) 2023-12-07 skia-flutter-autoroll@skia.org Roll Dart SDK from dbfe4e3f867e to be8a95b6717d (1 revision) (flutter/engine#48757) 2023-12-06 godofredoc@google.com Remove obsolete properties. (flutter/engine#48753) 2023-12-06 skia-flutter-autoroll@skia.org Roll Skia from 7ff0103760d0 to 2abb01e18ab3 (1 revision) (flutter/engine#48751) 2023-12-06 skia-flutter-autoroll@skia.org Roll Skia from 570103e08087 to 7ff0103760d0 (1 revision) (flutter/engine#48748) 2023-12-06 skia-flutter-autoroll@skia.org Roll Skia from 326bdc97ac40 to 570103e08087 (1 revision) (flutter/engine#48746) 2023-12-06 skia-flutter-autoroll@skia.org Roll Dart SDK from 6eb13603c212 to dbfe4e3f867e (1 revision) (flutter/engine#48745) 2023-12-06 jonahwilliams@google.com [Impeller] Store Buffer/Texture bindings in vector instead of map. (flutter/engine#48719) 2023-12-06 skia-flutter-autoroll@skia.org Roll Skia from 33cba437bf70 to 326bdc97ac40 (2 revisions) (flutter/engine#48743) 2023-12-06 jason-simmons@users.noreply.github.com [Impeller] Provide the clear color to an advanced blend if it was optimized out (flutter/engine#48646) 2023-12-06 737941+loic-sharma@users.noreply.github.com [Windows] Set swap interval on raster thread after startup (flutter/engine#47787) 2023-12-06 skia-flutter-autoroll@skia.org Roll Skia from 384d14063dc1 to 33cba437bf70 (3 revisions) (flutter/engine#48740) 2023-12-06 737941+loic-sharma@users.noreply.github.com [Windows] Refactor the GLES proc table (flutter/engine#48688) 2023-12-06 kjlubick@users.noreply.github.com Replace use of Fontmgr::RefDefault with explicit creation calls (flutter/engine#48571) 2023-12-06 jonahwilliams@google.com [Impeller] disable entity culling by default. (flutter/engine#48717) 2023-12-06 skia-flutter-autoroll@skia.org Roll Skia from 23e1cb20a6b5 to 384d14063dc1 (1 revision) (flutter/engine#48738) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This reverts commit ab89510.
The flutter/tests/skp_generator test (running in flutter_tester on Linux) was failing, along with some customer tests.