[Fuchsia] Use chromium test-scripts to download images and execute tests #49650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zijiehe-google-com
force-pushed
the
main
branch
from
12db7f8
to
e3b9d9e
Compare
zijiehe-google-com
changed the title
zijiehe-google-com
force-pushed
the
main
branch
from
4edc85f
to
e441a2a
Compare
cligh
reviewed
Jan 10, 2024
| # This file is expected to be executed from src/flutter/. | ||
|
|
||
|
|
||
| # TODO(https://github.com/flutter/flutter/issues/140179): Execute all the tests |
There was a problem hiding this comment.
Once this TODO is done, we can delete the Linux Fuchsia FEMU builds
\cc @keyonghan as FYI
|
@keyonghan this requires a second Flutter hacker to review. Can you take a look? |
keyonghan
reviewed
Jan 11, 2024
There was a problem hiding this comment.
Some lint errors need a fix: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8759159184604771825/+/u/test:_pylint/stdout
|
Yeap, I am fixing the pylint. |
keyonghan
added
the
autosubmit
|
Thank you all. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 12, 2024
8 tasks
|
FYI we ended up needing to update the engine_v2 dimensions as well. I sent #49770 as it's flaking on CI where it runs on bots without KVM. |
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 12, 2024
…141464) flutter/engine@ef2cf86...0ac8215 2024-01-12 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Use chromium test-scripts to download images and execute tests (flutter/engine#49650) 2024-01-12 skia-flutter-autoroll@skia.org Roll Skia from e04ca400c5d8 to 2bc5d2ee9896 (1 revision) (flutter/engine#49761) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
zanderso
reviewed
Jan 12, 2024
| @@ -1101,5 +1117,16 @@ hooks = [ | |||
| 'third_party/impeller-cmake-example', | |||
| '--setup', | |||
| ] | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
How big are these system images? Most Flutter engine developers aren't developing/testing for Fuchsia, so if these are bigger than a few MB, this download should be gated behind a gclient custom var or env variable that is set on CI.
There was a problem hiding this comment.
It's fairly large. We discussed if it was a common practice to have a download_fuchsia_deps to consider both host_os and target_os, but haven't found a similar approach for other platforms. #49650 (comment)
| @@ -0,0 +1,53 @@ | |||
| #!/usr/bin/env python3 | |||
| # Copyright (c) 2024, the Flutter project authors. All rights reserved. | |||
There was a problem hiding this comment.
The copyright year should be 2013 for all copyright headers in the engine repo.
| @@ -0,0 +1,59 @@ | |||
| #!/usr/bin/env python3 | |||
| # Copyright (c) 2024, the Flutter project authors. All rights reserved. | |||
There was a problem hiding this comment.
The copyright year should be 2013 for all copyright headers in the engine repo.
CaseyHillers
added
the
revert
|
@zijiehe-google-com I'm going to revert this as there's a few other follow up comments that should be addressed as well. If there's any issues with the follow ups, it'll make it easier to revert if this one PR instead of several PRs. |
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Jan 12, 2024
…xecute tests" (#49772) Reverts #49650 Initiated by: CaseyHillers This change reverts the following previous change: Original Description: This change requires flutter/buildroot#811, and can be executed from buildroot by ``` python3 flutter/tools/fuchsia/with_envs.py flutter/testing/fuchsia/run_tests.py ``` Bug: flutter/flutter#140179 - [V] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [V] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [V] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [V] I listed at least one issue that this PR fixes in the description above. - [V] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [V] I updated/added relevant documentation (doc comments with `///`). - [V] I signed the [CLA]. - [V] All existing and new tests are passing. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
|
SG, I will merge #49650 into the change as well. |
zanderso
pushed a commit
that referenced
this pull request
Jan 19, 2024
…cute tests (#49847) This change is a redo of #49650. https://github.com/zijiehe-google-com/engine/compare/de5c713..main should show the diff between this and the original change. Following paragraph is copied from the original change. This change requires flutter/buildroot#811, and can be executed from buildroot by ``` python3 flutter/tools/fuchsia/with_envs.py flutter/testing/fuchsia/run_tests.py ``` Bug: flutter/flutter#140179 ## Pre-launch Checklist - [V] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [V] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [V] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [V] I listed at least one issue that this PR fixes in the description above. - [V] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [V] I updated/added relevant documentation (doc comments with `///`). - [V] I signed the [CLA]. - [V] All existing and new tests are passing.
auto-submit bot
added a commit
that referenced
this pull request
Jan 19, 2024
…s and execute tests" (#49908) Reverts #49847 Initiated by: zanderso This change reverts the following previous change: Original Description: This change is a redo of #49650. https://github.com/zijiehe-google-com/engine/compare/de5c713..main should show the diff between this and the original change. Following paragraph is copied from the original change. This change requires flutter/buildroot#811, and can be executed from buildroot by ``` python3 flutter/tools/fuchsia/with_envs.py flutter/testing/fuchsia/run_tests.py ``` Bug: flutter/flutter#140179 - [V] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [V] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [V] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [V] I listed at least one issue that this PR fixes in the description above. - [V] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [V] I updated/added relevant documentation (doc comments with `///`). - [V] I signed the [CLA]. - [V] All existing and new tests are passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change requires flutter/buildroot#811, and can be executed from buildroot by
Bug: flutter/flutter#140179
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.